Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Tomi Valkeinen
Hi Andrew, (and Brian), On 18/03/15 00:08, Andrew Lunn wrote: This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access point and the C code is derived from code Belkin contributed to

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Andrew Lunn
Hi Tomi Our discussions were going around in circles, no progress being made. The subsystem maintainer is ultimately the one who needs to decide, bar Linus himself. Bryan Wu has seen all the discussions, and ultimately decided the driver was O.K, despite any unresolved issues you

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Tomi Valkeinen
On 17/08/15 16:27, Andrew Lunn wrote: On Mon, Aug 17, 2015 at 03:11:48PM +0300, Tomi Valkeinen wrote: Hi Andrew, (and Brian), (Sorry for typoing your name, Bryan =). On 18/03/15 00:08, Andrew Lunn wrote: This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Andrew Lunn
On Mon, Aug 17, 2015 at 03:11:48PM +0300, Tomi Valkeinen wrote: Hi Andrew, (and Brian), On 18/03/15 00:08, Andrew Lunn wrote: This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Bryan Wu
I apologize to ignore this email, since Jacek is taking over the maintainership of LED subsystem. Please include him in the email thread. Thanks, -Bryan On Mon, Aug 17, 2015 at 9:48 AM, Andrew Lunn and...@lunn.ch wrote: TLC591xx is quite simple HW, and the code doing the HW programming should

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Andrew Lunn
TLC591xx is quite simple HW, and the code doing the HW programming should be identical for a pwm and for a led driver. I don't see either a pwm or a led driver being somehow superior. They are very similar simple drivers, implementing a different interface. Whether the interface works for you

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Tomi Valkeinen
On 17/08/15 17:21, Andrew Lunn wrote: If you think your PWM code is so much better, please submit a revert patch plus your PWM LED driver. We can find somebody to do a side by side review. It's not about the driver code. That can be cleaned up if needed. The question is whether the driver

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-08-17 Thread Tomi Valkeinen
On 17/08/15 19:48, Andrew Lunn wrote: TLC591xx is quite simple HW, and the code doing the HW programming should be identical for a pwm and for a led driver. I don't see either a pwm or a led driver being somehow superior. They are very similar simple drivers, implementing a different

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-03-30 Thread Bryan Wu
On Sun, Mar 29, 2015 at 12:28 PM, Andrew Lunn and...@lunn.ch wrote: On Tue, Mar 17, 2015 at 11:08:25PM +0100, Andrew Lunn wrote: This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access

Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-03-29 Thread Andrew Lunn
On Tue, Mar 17, 2015 at 11:08:25PM +0100, Andrew Lunn wrote: This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access point and the C code is derived from code Belkin contributed to

[PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

2015-03-17 Thread Andrew Lunn
This patchset is a driver for the TI tlc59116 16 Channel i2c LED driver and tlc59108 8 Channel i2c LED driver. This driver is used on the Belkin WRT1900AC access point and the C code is derived from code Belkin contributed to OpenWRT. However it has been extensively re-written, and a device tree