Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-06-17 Thread Russell King - ARM Linux
On Fri, Jun 06, 2014 at 02:50:38PM -0500, Rob Herring wrote: Yes, they are okay. I'll ack the documentation once that is done. When someone documents the existing implmentation, then I'll add to it - I've not really looked into what the differences are between the compatible strings, so that's

Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-06-06 Thread Russell King - ARM Linux
On Thu, Apr 17, 2014 at 12:02:26AM +0100, Russell King - ARM Linux wrote: On Wed, Apr 16, 2014 at 11:57:21PM +0100, Russell King - ARM Linux wrote: On Wed, Apr 16, 2014 at 05:46:47PM -0500, Rob Herring wrote: On Wed, Apr 16, 2014 at 3:43 AM, Russell King rmk+ker...@arm.linux.org.uk wrote:

Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-06-06 Thread Rob Herring
On Fri, Jun 6, 2014 at 11:40 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Apr 17, 2014 at 12:02:26AM +0100, Russell King - ARM Linux wrote: On Wed, Apr 16, 2014 at 11:57:21PM +0100, Russell King - ARM Linux wrote: On Wed, Apr 16, 2014 at 05:46:47PM -0500, Rob Herring

[PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-04-16 Thread Russell King
Spread-spectrum doesn't work with Cubox-i hardware, so we have to disable this feature. Add a DT property so that platforms can indicate that this feature should not be enabled. Having it as a negative property keeps existing DT files working. Signed-off-by: Russell King

Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-04-16 Thread Rob Herring
On Wed, Apr 16, 2014 at 3:43 AM, Russell King rmk+ker...@arm.linux.org.uk wrote: Spread-spectrum doesn't work with Cubox-i hardware, so we have to disable this feature. Add a DT property so that platforms can indicate that this feature should not be enabled. This is for spread-spectrum tx or

Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-04-16 Thread Russell King - ARM Linux
On Wed, Apr 16, 2014 at 05:46:47PM -0500, Rob Herring wrote: On Wed, Apr 16, 2014 at 3:43 AM, Russell King rmk+ker...@arm.linux.org.uk wrote: Spread-spectrum doesn't work with Cubox-i hardware, so we have to disable this feature. Add a DT property so that platforms can indicate that this

Re: [PATCH RFC 5/5] ahci_imx: add disable for spread-spectrum

2014-04-16 Thread Russell King - ARM Linux
On Wed, Apr 16, 2014 at 11:57:21PM +0100, Russell King - ARM Linux wrote: On Wed, Apr 16, 2014 at 05:46:47PM -0500, Rob Herring wrote: On Wed, Apr 16, 2014 at 3:43 AM, Russell King rmk+ker...@arm.linux.org.uk wrote: Spread-spectrum doesn't work with Cubox-i hardware, so we have to