Byungho An bh74...@samsung.com :
[...]
+static int sxgbe_init_rx_buffers(struct net_device *dev,
+ struct sxgbe_rx_norm_desc *p, int i,
+ unsigned int dma_buf_sz,
+ struct sxgbe_rx_queue *rx_ring)
+{
+
Hi,
I have reviewed the non-net-specific parts of this driver, e.g. platform
driver and Device Tree code. Please see my comments inline.
On 22.03.2014 07:23, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe
On Sat, 2014-03-22 at 14:01 -0500, Vince Bridgers wrote:
See comments inline
Do please trim your comments instead of quoting the
_whole_ email.
--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Francois Romieu rom...@fr.zoreil.com wrote :
Byungho An bh74...@samsung.com :
[...]
+static int sxgbe_init_rx_buffers(struct net_device *dev,
+struct sxgbe_rx_norm_desc *p, int i,
+unsigned int dma_buf_sz,
+
Tomasz Figa tomasz.f...@gmail.com :
Hi,
I have reviewed the non-net-specific parts of this driver, e.g. platform
driver
and Device Tree code. Please see my comments inline.
On 22.03.2014 07:23, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for
On 22.03.2014 22:55, Byungho An wrote:
Tomasz Figa tomasz.f...@gmail.com :
[snip]
+ if (priv-irq = 0) {
+ dev_err(dev, sxgbe common irq parsing failed\n);
+ sxgbe_drv_remove(ndev);
+ return -EINVAL;
+ }
+
+ /* Get the TX/RX IRQ
Tomasz Figa tomasz.f...@gmail.com :
On 22.03.2014 22:55, Byungho An wrote:
Tomasz Figa tomasz.f...@gmail.com :
[snip]
+ if (priv-irq = 0) {
+ dev_err(dev, sxgbe common irq parsing failed\n);
+ sxgbe_drv_remove(ndev);
+ return -EINVAL;
+ }
+
+ /* Get
Vince Bridgers vbridgers2...@gmail.com :
See comments inline
On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
[snip]
+ /* program desc registers */
Vince Bridgers vbridgers2...@gmail.com :
On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
[snip]
+ /* Stop Advertising 1000BASE Capability if interface
