Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-29 Thread Mark Brown
On Wed, Apr 29, 2015 at 07:13:27AM -0700, Kevin Cernekee wrote: On Wed, Apr 29, 2015 at 3:40 AM, Mark Brown broo...@kernel.org wrote: Like I said above we can tell if the hardware was reset because mark_dirty() is called. That covers the public API, but I do not understand how you intended

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-28 Thread Kevin Cernekee
On Sat, Apr 25, 2015 at 4:32 AM, Mark Brown broo...@kernel.org wrote: On Fri, Apr 24, 2015 at 03:36:45PM -0700, Kevin Cernekee wrote: index 116655d92269..ece122a6fdeb 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -438,7 +438,7 @@ bool regmap_can_raw_write(struct regmap

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-25 Thread Lars-Peter Clausen
On 04/25/2015 12:36 AM, Kevin Cernekee wrote: regcache_sync() and regcache_sync_region() currently assume that the hardware has just emerged from a clean reset, and that all registers are in their default states. But that isn't the only possibility; the device may have been in a different state

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-25 Thread Mark Brown
On Fri, Apr 24, 2015 at 03:36:45PM -0700, Kevin Cernekee wrote: index 116655d92269..ece122a6fdeb 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -438,7 +438,7 @@ bool regmap_can_raw_write(struct regmap *map); int regcache_sync(struct regmap *map); int

[PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-24 Thread Kevin Cernekee
regcache_sync() and regcache_sync_region() currently assume that the hardware has just emerged from a clean reset, and that all registers are in their default states. But that isn't the only possibility; the device may have been in a different state in which the registers were inaccessible but

Re: [PATCH V2 1/4] regmap: cache: Add was_reset argument to regcache_sync_region()

2015-04-24 Thread Kevin Cernekee
On Fri, Apr 24, 2015 at 3:36 PM, Kevin Cernekee cerne...@chromium.org wrote: regcache_sync() and regcache_sync_region() currently assume that the hardware has just emerged from a clean reset, and that all registers are in their default states. But that isn't the only possibility; the device