Re: [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-04 Thread Sinan Kaya
/* * We are posting descriptors to the hardware as soon as * they are ready, so this function does nothing. */ So, the Freescale driver was written before change went effective. I guess in 2011 DMA Engine drivers should use issue pending. Please, refactor since this behaviour is expected.

Re: [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-04 Thread Andy Shevchenko
On Wed, Nov 4, 2015 at 2:07 AM, Sinan Kaya wrote: > On 11/3/2015 5:10 AM, Andy Shevchenko wrote: >> On Mon, Nov 2, 2015 at 8:07 AM, Sinan Kaya wrote: >>> +static void hidma_issue_pending(struct dma_chan *dmach) >>> +{ >> >> >> Wrong. It should

Re: [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-03 Thread Andy Shevchenko
On Mon, Nov 2, 2015 at 8:07 AM, Sinan Kaya wrote: > This patch adds support for hidma engine. The driver > consists of two logical blocks. The DMA engine interface > and the low-level interface. The hardware only supports > memcpy/memset and this driver only support memcpy >

Re: [PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-03 Thread Sinan Kaya
On 11/3/2015 5:10 AM, Andy Shevchenko wrote: On Mon, Nov 2, 2015 at 8:07 AM, Sinan Kaya wrote: This patch adds support for hidma engine. The driver consists of two logical blocks. The DMA engine interface and the low-level interface. The hardware only supports

[PATCH V2 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-01 Thread Sinan Kaya
This patch adds support for hidma engine. The driver consists of two logical blocks. The DMA engine interface and the low-level interface. The hardware only supports memcpy/memset and this driver only support memcpy interface. HW and driver doesn't support slave interface. Signed-off-by: Sinan