Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Shengjiu Wang
On Tue, Nov 24, 2015 at 05:21:30PM -0600, Rob Herring wrote: > On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > > ESAI need to enable the spba clock, when sdma is using share peripheral > > script. In this case, there is two spba master port is used, if don't > > enable the clock, t

Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Rob Herring
On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > ESAI need to enable the spba clock, when sdma is using share peripheral > script. In this case, there is two spba master port is used, if don't > enable the clock, the spba bus will have arbitration issue, which may > cause read/write

Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Shengjiu Wang
On Tue, Nov 24, 2015 at 12:33:45AM -0800, Nicolin Chen wrote: > On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > > > @@ -469,6 +471,9 @@ static int fsl_esai_startup(struct snd_pcm_substream > > *substream, > > ret = clk_prepare_enable(esai_priv->coreclk); > > if (ret) > >

Re: [PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-24 Thread Nicolin Chen
On Tue, Nov 24, 2015 at 03:03:28PM +0800, Shengjiu Wang wrote: > @@ -469,6 +471,9 @@ static int fsl_esai_startup(struct snd_pcm_substream > *substream, > ret = clk_prepare_enable(esai_priv->coreclk); > if (ret) > return ret; > + ret = clk_prepare_enable(esai_priv->sp

[PATCH V3 1/3] ASoC: fsl_esai: spba clock is needed by esai device

2015-11-23 Thread Shengjiu Wang
ESAI need to enable the spba clock, when sdma is using share peripheral script. In this case, there is two spba master port is used, if don't enable the clock, the spba bus will have arbitration issue, which may cause read/write wrong data from/to ESAI registers. Signed-off-by: Shengjiu Wang ---