Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-09 Thread Yuvaraj Kumar
On Wed, Jan 8, 2014 at 9:16 PM, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, January 08, 2014 06:39:52 PM Yuvaraj Kumar wrote: >> On Tue, Jan 7, 2014 at 7:52 PM, Bartlomiej Zolnierkiewicz >> wrote: >> > >> > Hi, >> > >> > On Thursday, January 02, 2014 07:03:23 PM Yuvaraj Kumar wrote: >> >> On

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-08 Thread Bartlomiej Zolnierkiewicz
On Wednesday, January 08, 2014 06:39:52 PM Yuvaraj Kumar wrote: > On Tue, Jan 7, 2014 at 7:52 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Thursday, January 02, 2014 07:03:23 PM Yuvaraj Kumar wrote: > >> On Tue, Dec 31, 2013 at 9:00 PM, Bartlomiej Zolnierkiewicz > >> wrote: > > >

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-08 Thread Yuvaraj Kumar
On Tue, Jan 7, 2014 at 7:52 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, January 02, 2014 07:03:23 PM Yuvaraj Kumar wrote: >> On Tue, Dec 31, 2013 at 9:00 PM, Bartlomiej Zolnierkiewicz >> wrote: > >> >> @@ -8,3 +8,4 @@ obj-$(CONFIG_PHY_EXYNOS_MIPI_VIDEO) += >> >> phy-exynos-mi

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-07 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, January 02, 2014 07:03:23 PM Yuvaraj Kumar wrote: > On Tue, Dec 31, 2013 at 9:00 PM, Bartlomiej Zolnierkiewicz > wrote: > >> @@ -8,3 +8,4 @@ obj-$(CONFIG_PHY_EXYNOS_MIPI_VIDEO) += > >> phy-exynos-mipi-video.o > >> obj-$(CONFIG_PHY_MVEBU_SATA) += phy-mvebu-sata.o > >

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-07 Thread Kishon Vijay Abraham I
On Thursday 02 January 2014 07:13 PM, Yuvaraj Kumar wrote: > On Tue, Dec 31, 2013 at 4:18 PM, Kishon Vijay Abraham I wrote: >> Hi Yuvaraj, >> >> >> On Monday 30 December 2013 06:37 PM, Yuvaraj Kumar C D wrote: >>> >>> This patch adds the sata phy driver for Exynos5250.Exynos5250 sata >>> phy compr

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-02 Thread Yuvaraj Kumar
On Tue, Dec 31, 2013 at 4:18 PM, Kishon Vijay Abraham I wrote: > Hi Yuvaraj, > > > On Monday 30 December 2013 06:37 PM, Yuvaraj Kumar C D wrote: >> >> This patch adds the sata phy driver for Exynos5250.Exynos5250 sata >> phy comprises of CMU and TRSV blocks which are of I2C register Map. >> So thi

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2014-01-02 Thread Yuvaraj Kumar
On Tue, Dec 31, 2013 at 9:00 PM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-ide ML to Cc: ] > > Hi, > > Overall the code looks good, thank you for working on this. Thanks for the review. > > I still have some review comments though.. Thats Good :) > > On Monday, December 30, 2013 06:37:02

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2013-12-31 Thread Bartlomiej Zolnierkiewicz
[ added linux-ide ML to Cc: ] Hi, Overall the code looks good, thank you for working on this. I still have some review comments though.. On Monday, December 30, 2013 06:37:02 PM Yuvaraj Kumar C D wrote: > This patch adds the sata phy driver for Exynos5250.Exynos5250 sata > phy comprises of CMU

Re: [PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2013-12-31 Thread Kishon Vijay Abraham I
Hi Yuvaraj, On Monday 30 December 2013 06:37 PM, Yuvaraj Kumar C D wrote: This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV b

[PATCH V4 1/2] Phy: Exynos: Add Exynos5250 sata phy driver

2013-12-30 Thread Yuvaraj Kumar C D
This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY. This patch incorporates the generic phy framewo