Re: [PATCH resend 2/2] i2c: hix5hd2: add i2c controller driver

2014-09-25 Thread Wolfram Sang
> >>+#include > >>+#include > >>+#include > >>+#include > >>+#include > >>+#include > >>+#include > >>+#include > > > >I think there should be at least of.h, too. > The of.h is already in i2c.h > include/linux/i2c.h:33:#include Please add it nonetheless, because you use e.g. of_property_

Re: [PATCH resend 2/2] i2c: hix5hd2: add i2c controller driver

2014-09-25 Thread zhangfei
Thanks Wolfram for the careful review On 09/20/2014 01:18 AM, Wolfram Sang wrote: Hi, thanks for the submission. --- /dev/null +++ b/drivers/i2c/busses/i2c-hix5hd2.c @@ -0,0 +1,573 @@ +/* + * Copyright (c) 2014 Linaro Ltd. + * Copyright (c) 2014 Hisilicon Limited. + * + * This program is fre

Re: [PATCH resend 2/2] i2c: hix5hd2: add i2c controller driver

2014-09-19 Thread Wolfram Sang
Hi, thanks for the submission. > --- /dev/null > +++ b/drivers/i2c/busses/i2c-hix5hd2.c > @@ -0,0 +1,573 @@ > +/* > + * Copyright (c) 2014 Linaro Ltd. > + * Copyright (c) 2014 Hisilicon Limited. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the te

[PATCH resend 2/2] i2c: hix5hd2: add i2c controller driver

2014-08-25 Thread Zhangfei Gao
From: Wei Yan I2C drivers for hix5hd2 soc series, including following chipset Hi3716CV200, Hi3719CV100, Hi3718CV100, Hi3719MV100, Hi3718MV100. Signed-off-by: Wei Yan Signed-off-by: Zhangfei Gao --- drivers/i2c/busses/Kconfig | 15 + drivers/i2c/busses/Makefile |1 + drivers/i