Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-02 Thread Daniel Lezcano
On 12/01/2014 07:50 PM, Lina Iyer wrote: On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: +static bool cpuidle_drv_init; ^ As already said in a previous comment, please find a way to remove that. I will look into it.

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-02 Thread Catalin Marinas
On Mon, Dec 01, 2014 at 06:57:05PM +, Lina Iyer wrote: On Thu, Nov 27 2014 at 08:01 -0700, Lorenzo Pieralisi wrote: On Thu, Nov 27, 2014 at 05:24:07AM +, Lina Iyer wrote: [...] +static int spm_set_low_power_mode(enum pm_sleep_mode mode) +{ + struct spm_driver_data *drv =

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-02 Thread Lina Iyer
On Tue, Dec 02 2014 at 02:53 -0700, Daniel Lezcano wrote: On 12/01/2014 07:50 PM, Lina Iyer wrote: On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: +static bool cpuidle_drv_init; ^ As already said in a previous comment,

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-02 Thread Daniel Lezcano
On 12/02/2014 04:35 PM, Lina Iyer wrote: On Tue, Dec 02 2014 at 02:53 -0700, Daniel Lezcano wrote: On 12/01/2014 07:50 PM, Lina Iyer wrote: On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: +static bool cpuidle_drv_init; ^

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-02 Thread Lina Iyer
On Tue, Dec 02 2014 at 04:10 -0700, Catalin Marinas wrote: On Mon, Dec 01, 2014 at 06:57:05PM +, Lina Iyer wrote: On Thu, Nov 27 2014 at 08:01 -0700, Lorenzo Pieralisi wrote: On Thu, Nov 27, 2014 at 05:24:07AM +, Lina Iyer wrote: [...] +static int spm_set_low_power_mode(enum

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-01 Thread Lina Iyer
Hi Ivan, On Thu, Nov 27 2014 at 01:43 -0700, Ivan T. Ivanov wrote: Hi, On Wed, 2014-11-26 at 22:24 -0700, Lina Iyer wrote: - compatible: @@ -14,10 +23,13 @@ PROPERTIES Value type: string Definition: shall contain qcom,saw2. A more specific value should be

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-01 Thread Lina Iyer
On Thu, Nov 27 2014 at 01:52 -0700, Daniel Lezcano wrote: On 11/27/2014 06:24 AM, Lina Iyer wrote: + static bool cpuidle_drv_init; ^ As already said in a previous comment, please find a way to remove that. I will look into it. Stephen and I wanted the cpuidle driver

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-12-01 Thread Lina Iyer
On Thu, Nov 27 2014 at 08:01 -0700, Lorenzo Pieralisi wrote: On Thu, Nov 27, 2014 at 05:24:07AM +, Lina Iyer wrote: [...] +static int spm_set_low_power_mode(enum pm_sleep_mode mode) +{ + struct spm_driver_data *drv = per_cpu(cpu_spm_drv, +

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-27 Thread Ivan T. Ivanov
Hi, On Wed, 2014-11-26 at 22:24 -0700, Lina Iyer wrote: - compatible: @@ -14,10 +23,13 @@ PROPERTIES Value type: string Definition: shall contain qcom,saw2. A more specific value should be one of: Which driver is supposed

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-27 Thread Daniel Lezcano
On 11/27/2014 06:24 AM, Lina Iyer wrote: SPM is a hardware block that controls the peripheral logic surrounding the application cores (cpu/l$). When the core executes WFI instruction, the SPM takes over the putting the core in low power state as configured. The wake up for the SPM is an

Re: [PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-27 Thread Lorenzo Pieralisi
On Thu, Nov 27, 2014 at 05:24:07AM +, Lina Iyer wrote: [...] +static int spm_set_low_power_mode(enum pm_sleep_mode mode) +{ + struct spm_driver_data *drv = per_cpu(cpu_spm_drv, + smp_processor_id()); + u32 start_index; +

[PATCH v13 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-26 Thread Lina Iyer
SPM is a hardware block that controls the peripheral logic surrounding the application cores (cpu/l$). When the core executes WFI instruction, the SPM takes over the putting the core in low power state as configured. The wake up for the SPM is an interrupt at the GIC, which then completes the rest