Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-06-11 Thread Vignesh R
Hi, On Thursday 11 June 2015 09:04 PM, Evgeniy Polyakov wrote: > Hi > > 25.05.2015, 08:15, "Vignesh R" : >>> HDQ mode remains unchanged. >>> >>> Signed-off-by: Vignesh R > > I have no experience with omap_hdq platform, but there are quite a few > questions > related to IO - you never check w

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-06-11 Thread Evgeniy Polyakov
Hi 25.05.2015, 08:15, "Vignesh R" : >>  HDQ mode remains unchanged. >> >>  Signed-off-by: Vignesh R I have no experience with omap_hdq platform, but there are quite a few questions related to IO - you never check whether write was successful or read returned actually valid data, is it ok? I mea

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-05-28 Thread Andrew Morton
On Mon, 18 May 2015 17:39:19 +0530 Vignesh R wrote: > This patches makes following changes to omap_hdq driver > - Enable 1-wire mode. > - Implement w1_triplet callback to facilitate search rom >procedure and auto detection of 1-wire slaves. > - Proper enabling and disabling of interrupt. >

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-05-24 Thread Vignesh R
On Monday 18 May 2015 05:39 PM, Vignesh R wrote: > This patches makes following changes to omap_hdq driver > - Enable 1-wire mode. > - Implement w1_triplet callback to facilitate search rom >procedure and auto detection of 1-wire slaves. > - Proper enabling and disabling of interrupt. > -