Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2016-01-05 Thread Peter Chen
On Tue, Jan 05, 2016 at 08:36:31AM -0600, Rob Herring wrote: > > 2. There are MFD USB devices, which includes several interfaces under > > USB device, > > like i2c, gpios, etc. Due to lack of device tree support, USB > > class/device driver doesn't know > > which kinds of interfaces are needed for

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2016-01-05 Thread Alan Stern
On Tue, 5 Jan 2016, Rob Herring wrote: > >>> > It's not clear (to me, anyway) how this is meant to work. USB is a > >>> > completely discoverable bus: There is no way to represent devices > >>> > statically; they have to be discovered. But a device can't be > >>> > discovered unless it is functi

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2016-01-05 Thread Rob Herring
On Mon, Dec 21, 2015 at 2:33 AM, Peter Chen wrote: > On Fri, Dec 18, 2015 at 11:38 PM, Alan Stern > wrote: >> On Fri, 18 Dec 2015, Peter Chen wrote: >> >>> On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern >>> wrote: >> >>> > It's not clear (to me, anyway) how this is meant to work. USB is a >>> >

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-22 Thread Alan Stern
On Tue, 22 Dec 2015, Peter Chen wrote: > > I don't really understand this. However, you can always specify a USB > > device by giving its port number on the parent hub, and the hub's port > > number on _its_ parent hub, and so on back to the root hub and host > > controller. That works even if y

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Tue, Dec 22, 2015 at 3:40 AM, Alan Stern wrote: > On Mon, 21 Dec 2015, Peter Chen wrote: > >> There are two problems which needs device tree to support, I have >> below solutions for them, please help to see if it is reasonable. >> >> 1. The USB device can't work without external clock, power,

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Alan Stern
On Mon, 21 Dec 2015, Peter Chen wrote: > There are two problems which needs device tree to support, I have > below solutions for them, please help to see if it is reasonable. > > 1. The USB device can't work without external clock, power, reset operation. > At device tree, we have a node to descr

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Sat, Dec 19, 2015 at 7:48 AM, Maciej S. Szmigiero wrote: > On 17.12.2015 07:57, Peter Chen wrote: >> On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: >>> Hi Fabio, >>> Hi Peter, >>> >>> On 16.12.2015 11:11, Fabio Estevam wrote: Hi Peter, On Wed, Dec 16, 2015 a

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Fri, Dec 18, 2015 at 11:38 PM, Alan Stern wrote: > On Fri, 18 Dec 2015, Peter Chen wrote: > >> On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern >> wrote: > >> > It's not clear (to me, anyway) how this is meant to work. USB is a >> > completely discoverable bus: There is no way to represent devic

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-18 Thread Maciej S. Szmigiero
On 17.12.2015 07:57, Peter Chen wrote: > On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: >> Hi Fabio, >> Hi Peter, >> >> On 16.12.2015 11:11, Fabio Estevam wrote: >>> Hi Peter, >>> >>> On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen >>> wrote: >>> Thanks, Fabio, but I am cur

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-18 Thread Alan Stern
On Fri, 18 Dec 2015, Peter Chen wrote: > On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern > wrote: > > It's not clear (to me, anyway) how this is meant to work. USB is a > > completely discoverable bus: There is no way to represent devices > > statically; they have to be discovered. But a device

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Peter Chen
On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern wrote: > On Wed, 16 Dec 2015, Rob Herring wrote: > >> On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: >> > On Monday 14 December 2015 15:26:11 Peter Chen wrote: >> >> Hi all, >> >> >> >> There is a known issue that the USB code can't handle USB H

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Peter Chen
On Thu, Dec 17, 2015 at 9:49 PM, Rob Herring wrote: > On Wed, Dec 16, 2015 at 8:31 PM, Peter Chen wrote: >> On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: >>> On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: >>> > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: >>>

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Alan Stern
On Wed, 16 Dec 2015, Rob Herring wrote: > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > >> Hi all, > >> > >> There is a known issue that the USB code can't handle USB HUB's > >> external pins well, in that case, it may cause some

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Rob Herring
On Wed, Dec 16, 2015 at 8:31 PM, Peter Chen wrote: > On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: >> On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: >> > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: >> > > On Monday 14 December 2015 15:26:11 Peter Chen wrote:

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: > Hi Fabio, > Hi Peter, > > On 16.12.2015 11:11, Fabio Estevam wrote: > > Hi Peter, > > > > On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen > > wrote: > > > >> Thanks, Fabio, but I am curious how things like that? The USBOH3 cloc

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: > > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > > > I agree on doing it properly, but am not sure tha

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Arnd Bergmann
On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > I agree on doing it properly, but am not sure that pwrseq binding for > MMC is proper. The pwrseq binding is fairly limite

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Rob Herring
On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > On Monday 14 December 2015 15:26:11 Peter Chen wrote: >> Hi all, >> >> There is a known issue that the USB code can't handle USB HUB's >> external pins well, in that case, it may cause some onboard >> USB HUBs can't work since their PHY's clo

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Maciej S. Szmigiero
Hi Fabio, Hi Peter, On 16.12.2015 11:11, Fabio Estevam wrote: > Hi Peter, > > On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen wrote: > >> Thanks, Fabio, but I am curious how things like that? The USBOH3 clock >> is not opened, the usb driver will hang when it tries to access >> registers. If this c

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Fabio Estevam
Hi Peter, On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen wrote: > Thanks, Fabio, but I am curious how things like that? The USBOH3 clock > is not opened, the usb driver will hang when it tries to access > registers. If this clock is always on, then, why the system will > hang later? I found the is

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-15 Thread Peter Chen
On Tue, Dec 15, 2015 at 09:32:18AM -0200, Fabio Estevam wrote: > On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote: > > > Thanks, Fabio. > > > > I am afraid I forget to set gpio as output, would you please apply > > below patch against my original ones: > > Same error happens with these changes

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-15 Thread Fabio Estevam
On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote: > Thanks, Fabio. > > I am afraid I forget to set gpio as output, would you please apply > below patch against my original ones: Same error happens with these changes applied. Here are more details: if I run a pure 4.3.2 then I do see the USB st

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-15 Thread Peter Chen
On Mon, Dec 14, 2015 at 10:35:19AM +0100, Arnd Bergmann wrote: > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > Hi all, > > > > There is a known issue that the USB code can't handle USB HUB's > > external pins well, in that case, it may cause some onboard > > USB HUBs can't work since t

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-14 Thread Peter Chen
On Mon, Dec 14, 2015 at 09:26:55AM -0200, Fabio Estevam wrote: > Hi Peter, > > On Mon, Dec 14, 2015 at 5:26 AM, Peter Chen wrote: > > > Hi all, > > > > There is a known issue that the USB code can't handle USB HUB's > > external pins well, in that case, it may cause some onboard > > USB HUBs can

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-14 Thread Fabio Estevam
Hi Peter, On Mon, Dec 14, 2015 at 5:26 AM, Peter Chen wrote: > Hi all, > > There is a known issue that the USB code can't handle USB HUB's > external pins well, in that case, it may cause some onboard > USB HUBs can't work since their PHY's clock or reset pin needs to > operate. > > The user rep

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-14 Thread Arnd Bergmann
On Monday 14 December 2015 15:26:11 Peter Chen wrote: > Hi all, > > There is a known issue that the USB code can't handle USB HUB's > external pins well, in that case, it may cause some onboard > USB HUBs can't work since their PHY's clock or reset pin needs to > operate. > > The user reported th

[PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-13 Thread Peter Chen
Changes for v2: - Delete platform data support for this driver - Delete '#define DEBUG' - Add "clock-frequency" entry for clock setting support - Set hub_data->clk as NULL if clk is nonexist, it can simply operation for optional clocks. - Delete gpio polarity entry, the polarity can passed by dts