Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2015-07-22 Thread Zhi Li
On Wed, Jul 22, 2015 at 1:15 PM, Zhi Li lzn...@gmail.com wrote: On Mon, Aug 4, 2014 at 9:25 AM, Mark Brown broo...@kernel.org wrote: On Sat, Aug 02, 2014 at 11:09:09AM +0200, Geert Uytterhoeven wrote: On Sat, Aug 2, 2014 at 4:06 AM, Brian Norris On Wed, Jul 30, 2014 at 11:46:07AM +0100, Mark

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2015-07-22 Thread Zhi Li
On Mon, Aug 4, 2014 at 9:25 AM, Mark Brown broo...@kernel.org wrote: On Sat, Aug 02, 2014 at 11:09:09AM +0200, Geert Uytterhoeven wrote: On Sat, Aug 2, 2014 at 4:06 AM, Brian Norris On Wed, Jul 30, 2014 at 11:46:07AM +0100, Mark Brown wrote: I don't know what DDR is in this context, sorry.

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-08-04 Thread Mark Brown
On Sat, Aug 02, 2014 at 11:09:09AM +0200, Geert Uytterhoeven wrote: On Sat, Aug 2, 2014 at 4:06 AM, Brian Norris On Wed, Jul 30, 2014 at 11:46:07AM +0100, Mark Brown wrote: I don't know what DDR is in this context, sorry. I think it's just the ability to latch data on both the rising and

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-08-02 Thread Geert Uytterhoeven
On Sat, Aug 2, 2014 at 4:06 AM, Brian Norris computersforpe...@gmail.com wrote: On Wed, Jul 30, 2014 at 11:46:07AM +0100, Mark Brown wrote: On Wed, Jul 30, 2014 at 12:45:00AM -0700, Brian Norris wrote: On Wed, Jul 30, 2014 at 02:44:13PM +0800, Huang Shijie wrote: IMHO, the DDR modes can

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-08-01 Thread Brian Norris
On Wed, Jul 30, 2014 at 11:46:07AM +0100, Mark Brown wrote: On Wed, Jul 30, 2014 at 12:45:00AM -0700, Brian Norris wrote: On Wed, Jul 30, 2014 at 02:44:13PM +0800, Huang Shijie wrote: IMHO, the DDR modes can _NOT_ be handled by the driver/spi/*. I agree to some extent, but I wanted to

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-07-30 Thread Huang Shijie
On Tue, Jul 29, 2014 at 10:08:43PM -0700, Brian Norris wrote: On Mon, Apr 28, 2014 at 11:53:40AM +0800, Huang Shijie wrote: This patch adds the DDR quad read support by the following: To Mark / linux-spi: Are DDR modes in the scope of drivers/spi/ at all, so that we could someday wire

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-07-30 Thread Brian Norris
+ Mark On Wed, Jul 30, 2014 at 02:44:13PM +0800, Huang Shijie wrote: On Tue, Jul 29, 2014 at 10:08:43PM -0700, Brian Norris wrote: On Mon, Apr 28, 2014 at 11:53:40AM +0800, Huang Shijie wrote: This patch adds the DDR quad read support by the following: To Mark / linux-spi: Are DDR

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-07-30 Thread Mark Brown
On Wed, Jul 30, 2014 at 12:45:00AM -0700, Brian Norris wrote: On Wed, Jul 30, 2014 at 02:44:13PM +0800, Huang Shijie wrote: On Tue, Jul 29, 2014 at 10:08:43PM -0700, Brian Norris wrote: On Mon, Apr 28, 2014 at 11:53:40AM +0800, Huang Shijie wrote: This patch adds the DDR quad read

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-07-30 Thread Huang Shijie
On Wed, Jul 30, 2014 at 12:45:00AM -0700, Brian Norris wrote: BTW, does your quadspi controller unconditionally support DDR, or is there any dependency on board/clock configuration? I'm just curious whether you need a DT binding to describe DDR support, or if (as long as the flash supports

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-07-29 Thread Brian Norris
Hi Huang, Sorry to address this series so late. I have a few questions about how you determine support for these DDR modes. On Mon, Apr 28, 2014 at 11:53:40AM +0800, Huang Shijie wrote: This patch adds the DDR quad read support by the following: To Mark / linux-spi: Are DDR modes in the

Re: [PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-04-28 Thread Marek Vasut
On Monday, April 28, 2014 at 05:53:40 AM, Huang Shijie wrote: This patch adds the DDR quad read support by the following: [1] add SPI_NOR_DDR_QUAD read mode. [2] add DDR Quad read opcodes: SPINOR_OP_READ_1_4_4_D / SPINOR_OP_READ4_1_4_4_D [3] add set_ddr_quad_mode() to

[PATCH v2 03/10] mtd: spi-nor: add DDR quad read support

2014-04-27 Thread Huang Shijie
This patch adds the DDR quad read support by the following: [1] add SPI_NOR_DDR_QUAD read mode. [2] add DDR Quad read opcodes: SPINOR_OP_READ_1_4_4_D / SPINOR_OP_READ4_1_4_4_D [3] add set_ddr_quad_mode() to initialize for the DDR quad read. Currently it only works for