Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Dong Aisheng
On Tue, Jul 08, 2014 at 01:20:18PM +0200, Marc Kleine-Budde wrote: > On 07/08/2014 01:08 PM, Dong Aisheng wrote: > > On Tue, Jul 08, 2014 at 12:41:41PM +0200, Marc Kleine-Budde wrote: > >> On 07/08/2014 12:30 PM, Dong Aisheng wrote: > Regarding the mram and the offsets: > > >

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Marc Kleine-Budde
On 07/08/2014 01:08 PM, Dong Aisheng wrote: > On Tue, Jul 08, 2014 at 12:41:41PM +0200, Marc Kleine-Budde wrote: >> On 07/08/2014 12:30 PM, Dong Aisheng wrote: Regarding the mram and the offsets: > fifo_addr = priv->mram_base + priv->rxf0_off + fgi * RXF0_ELEMENT_SIZE; > fifo_

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Dong Aisheng
On Tue, Jul 08, 2014 at 12:41:41PM +0200, Marc Kleine-Budde wrote: > On 07/08/2014 12:30 PM, Dong Aisheng wrote: > >> Regarding the mram and the offsets: > >> > >>> fifo_addr = priv->mram_base + priv->rxf0_off + fgi * RXF0_ELEMENT_SIZE; > >>> fifo_addr = priv->mram_base + priv->mram_off + priv-

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Marc Kleine-Budde
On 07/08/2014 12:30 PM, Dong Aisheng wrote: >> Regarding the mram and the offsets: >> >>> fifo_addr = priv->mram_base + priv->rxf0_off + fgi * RXF0_ELEMENT_SIZE; >>> fifo_addr = priv->mram_base + priv->mram_off + priv->txb_off; >> >> Why is rxf0_off used without the mram_off and txb_off wit

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Dong Aisheng
On Fri, Jul 04, 2014 at 06:23:04PM +0530, Varka Bhadram wrote: > On 07/04/2014 05:23 PM, Dong Aisheng wrote: > >The patch adds the basic CAN TX/RX function support for Bosch M_CAN > >controller. > >For TX, only one dedicated tx buffer is used for sending data. > >For RX, RXFIFO 0 is used for recei

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-08 Thread Dong Aisheng
On Mon, Jul 07, 2014 at 12:24:03PM +0200, Marc Kleine-Budde wrote: > On 07/07/2014 09:10 AM, Dong Aisheng wrote: > > On Fri, Jul 04, 2014 at 02:21:41PM +0200, Marc Kleine-Budde wrote: > >> On 07/04/2014 01:53 PM, Dong Aisheng wrote: > >>> The patch adds the basic CAN TX/RX function support for Bosc

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-07 Thread Marc Kleine-Budde
On 07/07/2014 09:10 AM, Dong Aisheng wrote: > On Fri, Jul 04, 2014 at 02:21:41PM +0200, Marc Kleine-Budde wrote: >> On 07/04/2014 01:53 PM, Dong Aisheng wrote: >>> The patch adds the basic CAN TX/RX function support for Bosch M_CAN >>> controller. >>> For TX, only one dedicated tx buffer is used f

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-07 Thread Dong Aisheng
On Fri, Jul 04, 2014 at 02:21:41PM +0200, Marc Kleine-Budde wrote: > On 07/04/2014 01:53 PM, Dong Aisheng wrote: > > The patch adds the basic CAN TX/RX function support for Bosch M_CAN > > controller. > > For TX, only one dedicated tx buffer is used for sending data. > > For RX, RXFIFO 0 is used f

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-04 Thread Varka Bhadram
On 07/04/2014 05:23 PM, Dong Aisheng wrote: The patch adds the basic CAN TX/RX function support for Bosch M_CAN controller. For TX, only one dedicated tx buffer is used for sending data. For RX, RXFIFO 0 is used for receiving data to avoid overflow. Rx FIFO 1 and Rx Buffers are not used currently

Re: [PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-04 Thread Marc Kleine-Budde
On 07/04/2014 01:53 PM, Dong Aisheng wrote: > The patch adds the basic CAN TX/RX function support for Bosch M_CAN > controller. > For TX, only one dedicated tx buffer is used for sending data. > For RX, RXFIFO 0 is used for receiving data to avoid overflow. > Rx FIFO 1 and Rx Buffers are not used

[PATCH v2 1/1] can: m_can: add Bosch M_CAN controller support

2014-07-04 Thread Dong Aisheng
The patch adds the basic CAN TX/RX function support for Bosch M_CAN controller. For TX, only one dedicated tx buffer is used for sending data. For RX, RXFIFO 0 is used for receiving data to avoid overflow. Rx FIFO 1 and Rx Buffers are not used currently, as well as Tx Event FIFO. Due to the messag