RE: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-21 Thread Kim, Milo
Hello Jonathan and Stanimir, > >> See Documentation/ABI/sysfs-bus-iio > >> Millivolts I think... We copied hwmon where possible. > > > > I'm a bit confused about these units. I searched references of > > iio_read_channel_processed() and found a few. > > > > The iio_hwmon expecting milivolts. On th

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-21 Thread Jonathan Cameron
On 18/09/14 10:57, Stanimir Varbanov wrote: > Hi Jonathan, > > On 09/15/2014 07:11 PM, Jonathan Cameron wrote: >> >> >> On September 15, 2014 3:12:50 PM GMT+01:00, Stanimir Varbanov >> wrote: >>> Hi Jonathan, >>> >>> Thanks for the review! >>> >>> On 09/13/2014 08:27 PM, Jonathan Cameron wrote:

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-18 Thread Stanimir Varbanov
Hi Jonathan, On 09/15/2014 07:11 PM, Jonathan Cameron wrote: > > > On September 15, 2014 3:12:50 PM GMT+01:00, Stanimir Varbanov > wrote: >> Hi Jonathan, >> >> Thanks for the review! >> >> On 09/13/2014 08:27 PM, Jonathan Cameron wrote: >>> On 13/09/14 00:27, Hartmut Knaack wrote: Stanimi

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-15 Thread Jonathan Cameron
On September 15, 2014 3:12:50 PM GMT+01:00, Stanimir Varbanov wrote: >Hi Jonathan, > >Thanks for the review! > >On 09/13/2014 08:27 PM, Jonathan Cameron wrote: >> On 13/09/14 00:27, Hartmut Knaack wrote: >>> Stanimir Varbanov schrieb, Am 11.09.2014 17:13: The voltage ADC is peripheral of Q

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-15 Thread Stanimir Varbanov
Thanks for the comments! On 09/13/2014 02:27 AM, Hartmut Knaack wrote: > Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >> 15bits resolution and register space inside PMIC accessible across >> SPMI bus. >> >> The vadc driver reg

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-15 Thread Stanimir Varbanov
Hi Jonathan, Thanks for the review! On 09/13/2014 08:27 PM, Jonathan Cameron wrote: > On 13/09/14 00:27, Hartmut Knaack wrote: >> Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >>> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >>> 15bits resolution and register space inside P

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-13 Thread Jonathan Cameron
On 13/09/14 00:27, Hartmut Knaack wrote: > Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >> 15bits resolution and register space inside PMIC accessible across >> SPMI bus. >> >> The vadc driver registers itself through IIO inter

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-12 Thread Hartmut Knaack
Stanimir Varbanov schrieb, Am 11.09.2014 17:13: > The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has > 15bits resolution and register space inside PMIC accessible across > SPMI bus. > > The vadc driver registers itself through IIO interface. > Looks already pretty good. Things you

[PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-11 Thread Stanimir Varbanov
The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15bits resolution and register space inside PMIC accessible across SPMI bus. The vadc driver registers itself through IIO interface. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- drivers/iio/adc/Kconfig