Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-06-02 Thread Michal Simek
On 05/29/2014 03:19 PM, Mark Rutland wrote: On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: Hi Mark, +static struct of_device_id cdns_wdt_of_match[] = { + { .compatible = xlnx,zynq-wdt-r1p2, }, + { .compatible = cdns,wdt-r1p2, }, If these can currently be handled

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-06-02 Thread Mark Rutland
On Mon, Jun 02, 2014 at 07:25:16AM +0100, Michal Simek wrote: On 05/29/2014 03:19 PM, Mark Rutland wrote: On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: Hi Mark, +static struct of_device_id cdns_wdt_of_match[] = { + { .compatible = xlnx,zynq-wdt-r1p2, }, + {

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-06-02 Thread Michal Simek
On 06/02/2014 03:17 PM, Mark Rutland wrote: On Mon, Jun 02, 2014 at 07:25:16AM +0100, Michal Simek wrote: On 05/29/2014 03:19 PM, Mark Rutland wrote: On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: Hi Mark, +static struct of_device_id cdns_wdt_of_match[] = { + {

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-05-29 Thread Mark Rutland
On Tue, May 27, 2014 at 11:18:14AM +0100, Harini Katakam wrote: Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam hari...@xilinx.com --- Sorry for the delay in sending v2. v2 changes: - Update IO helpers. - Use dev_dbg instead of dev_info where possible.

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-05-29 Thread Harini Katakam
Hi Mark, On Thu, May 29, 2014 at 2:51 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, May 27, 2014 at 11:18:14AM +0100, Harini Katakam wrote: Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam hari...@xilinx.com --- Sorry for the delay in sending v2.

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-05-29 Thread Michal Simek
Hi Mark, +static struct of_device_id cdns_wdt_of_match[] = { + { .compatible = xlnx,zynq-wdt-r1p2, }, + { .compatible = cdns,wdt-r1p2, }, If these can currently be handled identically, why not just have cdns,wdt-r1p2 in the driver and in your dts have: compatible =

Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-05-29 Thread Mark Rutland
On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: Hi Mark, +static struct of_device_id cdns_wdt_of_match[] = { + { .compatible = xlnx,zynq-wdt-r1p2, }, + { .compatible = cdns,wdt-r1p2, }, If these can currently be handled identically, why not just have

[PATCH v2 1/2] watchdog: Add Cadence WDT driver

2014-05-27 Thread Harini Katakam
Add Cadence WDT driver. This is used by Xilinx Zynq. Signed-off-by: Harini Katakam hari...@xilinx.com --- Sorry for the delay in sending v2. v2 changes: - Update IO helpers. - Use dev_dbg instead of dev_info where possible. - Use watchdog_init_timeout - Spinlock for restart register where