Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-18 Thread Stathis Voukelatos
On 17/02/15 17:30, Mark Rutland wrote: It is the frequency of the timestamp values supplied to the sniffer module. It is used by the driver to convert to nanoseconds. I was trying to be somewhat generic here and not assume that it is necessarily the same as the 'tstamp' clock below, in which

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-18 Thread Stathis Voukelatos
Hi Mark, On 18/02/15 12:11, Mark Rutland wrote: Counters can often have a divider applied to their input clock and therefore run at a scaled down frequency. This is not the case in the first SoC where the sniffer is used, so for simplicity I can modify as you suggest and remove that field

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-18 Thread Mark Rutland
On Wed, Feb 18, 2015 at 09:40:22AM +, Stathis Voukelatos wrote: On 17/02/15 17:30, Mark Rutland wrote: It is the frequency of the timestamp values supplied to the sniffer module. It is used by the driver to convert to nanoseconds. I was trying to be somewhat generic here and not

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Stathis Voukelatos
Hi Mark, On 17/02/15 16:35, Mark Rutland wrote: +- tstamp-hz : frequency of the timestamp counter Is this the frequency the clock is running at, or a frequency that it should be programmed to in order to be used? The former can be queried from the common clock framework, and if you

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Mark Rutland
On Tue, Feb 17, 2015 at 04:22:04PM +, Stathis Voukelatos wrote: Hi Mark, On 17/02/15 14:51, Mark Rutland wrote: +Matched packet bytes and timestamp values are returned through a +FIFO. Timestamps are provided to the module through an externally +generated Gray-encoded counter.

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Stathis Voukelatos
Hi Mark, On 17/02/15 14:51, Mark Rutland wrote: +Matched packet bytes and timestamp values are returned through a +FIFO. Timestamps are provided to the module through an externally +generated Gray-encoded counter. Does this counter unit need to be enabled (or have any input clocks enabled)?

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Sergei Shtylyov
Hello. On 02/17/2015 05:03 PM, Stathis Voukelatos wrote: Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk [...] diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index d443279..891c224 100644 ---

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Mark Rutland
On Tue, Feb 17, 2015 at 02:03:31PM +, Stathis Voukelatos wrote: Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk --- .../bindings/net/linn-ether-packet-sniffer.txt | 42 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 + 2 files

[PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Stathis Voukelatos
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk --- .../bindings/net/linn-ether-packet-sniffer.txt | 42 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 + 2 files changed, 43 insertions(+) create mode 100644

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Mark Rutland
On Tue, Feb 17, 2015 at 05:13:19PM +, Stathis Voukelatos wrote: Hi Mark, On 17/02/15 16:35, Mark Rutland wrote: +- tstamp-hz : frequency of the timestamp counter Is this the frequency the clock is running at, or a frequency that it should be programmed to in order to be used?