Re: [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver

2013-12-12 Thread Linus Walleij
On Wed, Dec 11, 2013 at 2:42 AM, Stephen Boyd wrote: > On 12/10/13 00:10, Bjorn Andersson wrote: >> On Fri 06 Dec 13:40 PST 2013, Stephen Boyd wrote: +config PINCTRL_MSM + bool >>> Why not tristate? >>> >> I have a hard time seeing an situation where you would like to build a system

Re: [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver

2013-12-10 Thread Stephen Boyd
On 12/10/13 00:10, Bjorn Andersson wrote: > On Fri 06 Dec 13:40 PST 2013, Stephen Boyd wrote: >>> +config PINCTRL_MSM >>> + bool >> Why not tristate? >> > I have a hard time seeing an situation where you would like to build a system > with this driver as a module; it would force almost the enti

Re: [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver

2013-12-09 Thread Bjorn Andersson
On Fri 06 Dec 13:40 PST 2013, Stephen Boyd wrote: > General nitpick: There seems to be a lot of checks for invalid input in > the op functions. I hope that they're all unnecessary debugging that can > be removed. > Most of them checks that a gpio number is not larger than the number of pingroup

Re: [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver

2013-12-06 Thread Stephen Boyd
General nitpick: There seems to be a lot of checks for invalid input in the op functions. I hope that they're all unnecessary debugging that can be removed. On 12/05/13 18:10, Bjorn Andersson wrote: > This adds a pinctrl, pinmux, pinconf and gpiolib driver for the > Qualcomm TLMM block. > > Signed

[PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver

2013-12-05 Thread Bjorn Andersson
This adds a pinctrl, pinmux, pinconf and gpiolib driver for the Qualcomm TLMM block. Signed-off-by: Bjorn Andersson --- drivers/pinctrl/Kconfig |6 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-msm.c | 1028 + drivers/pinctrl/