Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

On 4 January 2016 at 21:39, Philipp Zabel wrote: > Am Samstag, den 19.12.2015, 11:55 +0100 schrieb Hans de Goede: >> On 18-12-15 12:08, Maxime Ripard wrote: >> > - If the reset line is in a !exclusive use with more than 1 user, >> >the refcount is modified

Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Am Samstag, den 19.12.2015, 11:55 +0100 schrieb Hans de Goede: > On 18-12-15 12:08, Maxime Ripard wrote: [...] > > I guess we could also have something like this: > > > >* The driver gets the reference to the reset line using > > reset_control_get or its shared variant. > > > > - If

Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi, On 18-12-15 12:08, Maxime Ripard wrote: On Wed, Dec 16, 2015 at 12:21:48PM +0100, Philipp Zabel wrote: Hi Maxime, Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: Am Montag, den 14.12.2015, 10:36 +0100 schrieb

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

On Wed, Dec 16, 2015 at 12:21:48PM +0100, Philipp Zabel wrote: > Hi Maxime, > > Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > > Hi, > > >

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi Maxime, Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > Hi, > > > > > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > >

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > Hi, > > > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > > index

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi Hans, Am Freitag, den 11.12.2015, 19:21 +0100 schrieb Hans de Goede: [...] > >> @@ -119,13 +134,55 @@ EXPORT_SYMBOL_GPL(reset_control_assert); > >> int reset_control_deassert(struct reset_control *rstc) > >> { > > > > Maybe WARN_ON(rstc->line->refcnt > 1) ? > > I assume you mean

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi, On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > diff --git a/include/linux/reset.h b/include/linux/reset.h > index c4c097d..1cca8ce 100644 > --- a/include/linux/reset.h > +++ b/include/linux/reset.h > @@ -11,6 +11,8 @@ int reset_control_reset(struct reset_control *rstc); >

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > Hi, > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index c4c097d..1cca8ce 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h >

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi Hans, thanks for moving this forward. Am Freitag, den 11.12.2015, 16:41 +0100 schrieb Hans de Goede: > Add reset_control_deassert_shared / reset_control_assert_shared > functions which are intended for use by drivers for hw blocks which > (may) share a reset line with another driver / hw

[PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Add reset_control_deassert_shared / reset_control_assert_shared functions which are intended for use by drivers for hw blocks which (may) share a reset line with another driver / hw block. Unlike the regular reset_control_[de]assert functions these functions keep track of how often

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Hi, On 11-12-15 18:10, Philipp Zabel wrote: Hi Hans, thanks for moving this forward. Thanks for the quick review, I've a couple of (simple) questions about your review remarks once those are cleared up I'll post a new version (of just this patch). Am Freitag, den 11.12.2015, 16:41 +0100