Re: [PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only"

2015-09-03 Thread Marc Zyngier
On 02/09/15 23:23, Bjorn Helgaas wrote: > On Fri, Aug 14, 2015 at 04:08:10PM -0500, Rob Herring wrote: >> On Fri, Aug 14, 2015 at 11:19 AM, Marc Zyngier wrote: >>> Both pci-host-generic and Pseries parse the "linux,pci-probe-only" >>> to engage the PCI_PROBE_ONLY mode, and both have a subtle bug t

Re: [PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only"

2015-09-02 Thread Bjorn Helgaas
On Fri, Aug 14, 2015 at 04:08:10PM -0500, Rob Herring wrote: > On Fri, Aug 14, 2015 at 11:19 AM, Marc Zyngier wrote: > > Both pci-host-generic and Pseries parse the "linux,pci-probe-only" > > to engage the PCI_PROBE_ONLY mode, and both have a subtle bug that > > can be triggered if the property ha

Re: [PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only"

2015-08-14 Thread Rob Herring
On Fri, Aug 14, 2015 at 11:19 AM, Marc Zyngier wrote: > Both pci-host-generic and Pseries parse the "linux,pci-probe-only" > to engage the PCI_PROBE_ONLY mode, and both have a subtle bug that > can be triggered if the property has no parameter. Humm, I bet we could break a lot of machines if we f

[PATCH v2 1/4] of/pci: Add of_pci_check_probe_only to parse "linux,pci-probe-only"

2015-08-14 Thread Marc Zyngier
Both pci-host-generic and Pseries parse the "linux,pci-probe-only" to engage the PCI_PROBE_ONLY mode, and both have a subtle bug that can be triggered if the property has no parameter. Provide a generic implementation that can be used by both. Signed-off-by: Marc Zyngier --- drivers/of/of_pci.c