Re: [PATCH v2 1/6] drm/exynos: add Exynos5433 decon driver

2015-03-25 Thread Hyungwon Hwang
Dear Daniel, On Wed, 18 Mar 2015 12:24:40 + Daniel Stone dan...@fooishbar.org wrote: Hi, Some feedback comments - most of these are not unique to your 5433 DECON driver but endemic throughout Exynos, so I don't blame you for them - but they should be fixed anyway. On 18 March 2015 at

[PATCH v2 1/6] drm/exynos: add Exynos5433 decon driver

2015-03-18 Thread Hyungwon Hwang
From: Joonyoung Shim jy0922.s...@samsung.com DECON(Display and Enhancement Controller) is new IP replacing FIMD in Exynos5433. This patch adds Exynos5433 decon driver. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Hyungwon Hwang human.hw...@samsung.com --- Changes for v2:

Re: [PATCH v2 1/6] drm/exynos: add Exynos5433 decon driver

2015-03-18 Thread Daniel Stone
Hi, Some feedback comments - most of these are not unique to your 5433 DECON driver but endemic throughout Exynos, so I don't blame you for them - but they should be fixed anyway. On 18 March 2015 at 08:16, Hyungwon Hwang human.hw...@samsung.com wrote: +static void decon_dpms_on(struct