Re: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver

2014-05-28 Thread zhangfei
On 05/27/2014 09:57 PM, Mark Rutland wrote: On Tue, May 27, 2014 at 01:44:27PM +0100, Zhangfei Gao wrote: Add support for the hix5hd2 XGMAC 1Gb ethernet device. The controller requires two queues for tx and two queues for rx. Controller fetch buffer from free queue and then push to used

[PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver

2014-05-27 Thread Zhangfei Gao
Add support for the hix5hd2 XGMAC 1Gb ethernet device. The controller requires two queues for tx and two queues for rx. Controller fetch buffer from free queue and then push to used queue. Diver should prepare free queue and free buffer from used queue. Signed-off-by: Zhangfei Gao

Re: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver

2014-05-27 Thread Tobias Klauser
On 2014-05-27 at 14:44:27 +0200, Zhangfei Gao zhangfei@linaro.org wrote: Add support for the hix5hd2 XGMAC 1Gb ethernet device. The controller requires two queues for tx and two queues for rx. Controller fetch buffer from free queue and then push to used queue. Diver should prepare free

Re: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver

2014-05-27 Thread Mark Rutland
On Tue, May 27, 2014 at 01:44:27PM +0100, Zhangfei Gao wrote: Add support for the hix5hd2 XGMAC 1Gb ethernet device. The controller requires two queues for tx and two queues for rx. Controller fetch buffer from free queue and then push to used queue. Diver should prepare free queue and free

Re: [PATCH v2 2/2] net: hisilicon: add hix5hd2 mac driver

2014-05-27 Thread zhangfei
On 05/27/2014 09:02 PM, Tobias Klauser wrote: On 2014-05-27 at 14:44:27 +0200, Zhangfei Gao zhangfei@linaro.org wrote: +static struct net_device_stats *hix5hd2_net_get_stats(struct net_device *dev) +{ + return dev-stats; +} This function can be omitted, since it corresponds to