Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Arnd Bergmann
On Sunday 05 January 2014, Hans de Goede wrote: Also, please send the binding as a separate patch with Cc to the devicetree-discuss mailing list. Hmm, this contradicts what others are saying who have requested for the binding docs to be part of the same commit as the driver (with

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Olliver Schinagl
On 01/04/14 22:47, Arnd Bergmann wrote: On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote: +Required properties: +- compatible : compatible list, contains allwinner,sun4i-a10-ahci +- reg: registers mapping +- interrupts : interrupt mapping for AHCI IRQ +- clocks :

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Hans de Goede
Hi, On 01/05/2014 01:42 PM, Olliver Schinagl wrote: On 01/04/14 22:47, Arnd Bergmann wrote: On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote: +Required properties: +- compatible : compatible list, contains allwinner,sun4i-a10-ahci +- reg: registers mapping +-

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Hans de Goede
Hi, On 01/05/2014 12:35 PM, Arnd Bergmann wrote: On Sunday 05 January 2014, Hans de Goede wrote: snip +static int sunxi_ahci_phy_init(struct device *dev, void __iomem *reg_base) +{ + u32 reg_val; + int timeout; + + /* This magic is from the original code */ +

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Hans de Goede
Hi, On 01/05/2014 01:42 PM, Olliver Schinagl wrote: On 01/04/14 22:47, Arnd Bergmann wrote: On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote: +Required properties: +- compatible : compatible list, contains allwinner,sun4i-a10-ahci +- reg: registers mapping +-

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-05 Thread Olliver Schinagl
On 01/05/14 14:32, Hans de Goede wrote: Hi, On 01/05/2014 01:42 PM, Olliver Schinagl wrote: On 01/04/14 22:47, Arnd Bergmann wrote: On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote: +Required properties: +- compatible : compatible list, contains allwinner,sun4i-a10-ahci +- reg

[PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-04 Thread Hans de Goede
From: Oliver Schinagl oli...@schinagl.nl This patch adds support for the ahci sata controler found on Allwinner A10 and A20 SoCs. Orignally written by Olliver Schinagl using the approach of having a platform device which probe method creates a new child platform device which gets driven by

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-04 Thread Arnd Bergmann
On Saturday 04 January 2014 10:14:36 Hans de Goede wrote: diff --git a/Documentation/devicetree/bindings/ata/ahci-sunxi.txt b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt new file mode 100644 index 000..0792fa5 --- /dev/null +++

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-04 Thread Arnd Bergmann
On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote: +Required properties: +- compatible : compatible list, contains allwinner,sun4i-a10-ahci +- reg: registers mapping +- interrupts : interrupt mapping for AHCI IRQ +- clocks : clocks for ACHI +- clock-names

Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

2014-01-04 Thread Hans de Goede
Hi, On 01/04/2014 10:39 PM, Arnd Bergmann wrote: On Saturday 04 January 2014 10:14:36 Hans de Goede wrote: diff --git a/Documentation/devicetree/bindings/ata/ahci-sunxi.txt b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt new file mode 100644 index 000..0792fa5 --- /dev/null +++