Re: [linux-sunxi] Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

On Mon, Dec 14, 2015 at 05:07:47PM +0100, Hans de Goede wrote: > >>+static int sun4i_codec_spk_event(struct snd_soc_dapm_widget *w, > >>+struct snd_kcontrol *k, int event) > >>+{ > >>+ struct sun4i_codec *scodec = snd_soc_card_get_drvdata(w->dapm->card); > >>+ > >>+

Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

Hi, On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote: > Add support for PA gpio pin for controlling an external amplifier as used > on some Allwinner boards. > > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Use a dapm speaker widget (SND_SOC_DAPM_SPK)

Re: [linux-sunxi] Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

Hi, On 14-12-15 16:56, Maxime Ripard wrote: Hi, On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote: Add support for PA gpio pin for controlling an external amplifier as used on some Allwinner boards. Signed-off-by: Hans de Goede --- Changes in v2: -Use a dapm

Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote: > Add support for PA gpio pin for controlling an external amplifier as used > on some Allwinner boards. > > Signed-off-by: Hans de Goede Acked-by: Rob Herring > --- > Changes in v2: > -Use a

Re: [PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

On Fri, Dec 11, 2015 at 07:43:57PM +0100, Hans de Goede wrote: > + gpiod_set_value_cansleep(scodec->gpio_pa, > + !!SND_SOC_DAPM_EVENT_ON(event)); Why the double negation here? The macro is already supposed to give you a boolean and

[PATCH v2 2/4] ASoC: sun4i-codec: Add support for PA gpio pin

Add support for PA gpio pin for controlling an external amplifier as used on some Allwinner boards. Signed-off-by: Hans de Goede --- Changes in v2: -Use a dapm speaker widget (SND_SOC_DAPM_SPK) to control the gpio -Rename gpio in devicetree from pa-gpios to