Re: [linux-sunxi] Re: [PATCH v2 3/4] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs

2015-06-25 Thread Lee Jones
On Wed, 24 Jun 2015, Hans de Goede wrote: On 24-06-15 13:23, Lee Jones wrote: Add a cell for the usb power_supply part of the axp20x PMICs. Why are you duplicating the subject line? Heh, because some maintainers insist that the main-body part of the commit message must stand by itself,

Re: [PATCH v2 3/4] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs

2015-06-24 Thread Lee Jones
Add a cell for the usb power_supply part of the axp20x PMICs. Why are you duplicating the subject line? Note that this cell is only for the usb power_supply part and not the ac-power / battery-charger / rtc-backup-bat-charger bits. Depending on the board each of those must be enabled /

Re: [linux-sunxi] Re: [PATCH v2 3/4] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs

2015-06-24 Thread Hans de Goede
Hi, On 24-06-15 13:23, Lee Jones wrote: Add a cell for the usb power_supply part of the axp20x PMICs. Why are you duplicating the subject line? Heh, because some maintainers insist that the main-body part of the commit message must stand by itself, without needing the subject to be

[PATCH v2 3/4] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs

2015-06-13 Thread Hans de Goede
Add a cell for the usb power_supply part of the axp20x PMICs. Note that this cell is only for the usb power_supply part and not the ac-power / battery-charger / rtc-backup-bat-charger bits. Depending on the board each of those must be enabled / disabled separately in devicetree as most boards do