Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-03 Thread Ley Foon Tan
On Mon, Aug 3, 2015 at 6:53 PM, Marc Zyngier wrote: > On 03/08/15 11:37, Ley Foon Tan wrote: + msg->address_lo = lower_32_bits(addr); + msg->address_hi = upper_32_bits(addr); + msg->data = data->hwirq; + + mask = msi_readl(msi, MSI_INTMASK); + mas

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-03 Thread Marc Zyngier
On 03/08/15 11:37, Ley Foon Tan wrote: > On Fri, Jul 31, 2015 at 8:12 PM, Marc Zyngier wrote: >> On 31/07/15 11:15, Ley Foon Tan wrote: >>> This patch adds Altera PCIe MSI driver. This soft IP supports configurable >>> number of vectors, which is a dts parameter. >> >> I've reviewed the initial dr

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-08-03 Thread Ley Foon Tan
On Fri, Jul 31, 2015 at 8:12 PM, Marc Zyngier wrote: > On 31/07/15 11:15, Ley Foon Tan wrote: >> This patch adds Altera PCIe MSI driver. This soft IP supports configurable >> number of vectors, which is a dts parameter. > > I've reviewed the initial drop of this code; basic courtesy would be to >

Re: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-07-31 Thread Marc Zyngier
On 31/07/15 11:15, Ley Foon Tan wrote: > This patch adds Altera PCIe MSI driver. This soft IP supports configurable > number of vectors, which is a dts parameter. I've reviewed the initial drop of this code; basic courtesy would be to keep me CCed on the follow-up series. > > Signed-off-by: Ley

[PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver

2015-07-31 Thread Ley Foon Tan
This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c | 324 +++