Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-03-04 Thread Will Deacon
On Mon, Mar 03, 2014 at 02:04:17PM +, Rob Herring wrote: > Adding Will... Thanks Rob! > On Fri, Feb 28, 2014 at 9:24 AM, Arnd Bergmann wrote: > > On Friday 28 February 2014 09:14:19 Rob Herring wrote: > >> > >> I know Will D was not a fan of this property. Primarily I believe > >> because yo

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-03-03 Thread Rob Herring
Adding Will... On Fri, Feb 28, 2014 at 9:24 AM, Arnd Bergmann wrote: > On Friday 28 February 2014 09:14:19 Rob Herring wrote: >> >> I know Will D was not a fan of this property. Primarily I believe >> because you may need to describe more than just a boolean in more >> complex bus topologies. > >

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-03-02 Thread Catalin Marinas
On Fri, Feb 28, 2014 at 09:17:08AM -0500, Santosh Shilimkar wrote: > On Friday 28 February 2014 04:39 AM, Arnd Bergmann wrote: > > On Thursday 27 February 2014 16:17:49 Santosh Shilimkar wrote: > >> + > >> +/** > >> + * of_dma_is_coherent - Check if device is coherent > >> + * @np:device no

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-28 Thread Arnd Bergmann
On Friday 28 February 2014 09:14:19 Rob Herring wrote: > > I know Will D was not a fan of this property. Primarily I believe > because you may need to describe more than just a boolean in more > complex bus topologies. I can't think of any example where it's not per-device. Do you think we can en

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-28 Thread Santosh Shilimkar
On Friday 28 February 2014 10:14 AM, Rob Herring wrote: > On Fri, Feb 28, 2014 at 3:39 AM, Arnd Bergmann wrote: >> On Thursday 27 February 2014 16:17:49 Santosh Shilimkar wrote: >>> + >>> +/** >>> + * of_dma_is_coherent - Check if device is coherent >>> + * @np:device node >>> + * >>> + *

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-28 Thread Rob Herring
On Fri, Feb 28, 2014 at 3:39 AM, Arnd Bergmann wrote: > On Thursday 27 February 2014 16:17:49 Santosh Shilimkar wrote: >> + >> +/** >> + * of_dma_is_coherent - Check if device is coherent >> + * @np:device node >> + * >> + * It returns true if "dma-coherent" property was found >> + * for t

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-28 Thread Santosh Shilimkar
On Friday 28 February 2014 04:39 AM, Arnd Bergmann wrote: > On Thursday 27 February 2014 16:17:49 Santosh Shilimkar wrote: >> + >> +/** >> + * of_dma_is_coherent - Check if device is coherent >> + * @np:device node >> + * >> + * It returns true if "dma-coherent" property was found >> + * fo

Re: [PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-28 Thread Arnd Bergmann
On Thursday 27 February 2014 16:17:49 Santosh Shilimkar wrote: > + > +/** > + * of_dma_is_coherent - Check if device is coherent > + * @np:device node > + * > + * It returns true if "dma-coherent" property was found > + * for this device in DT. > + */ > +bool of_dma_is_coherent(struct devic

[PATCH v2 4/7] dma: of: introduce of_dma_is_coherent() helper

2014-02-27 Thread Santosh Shilimkar
The of_dma_is_coherent() helper parses the given DT device node to see if the "dma-coherent" property is supported and returns true or false accordingly. Cc: Russell King Cc: Arnd Bergmann Cc: Olof Johansson Cc: Grant Likely Cc: Rob Herring Signed-off-by: Santosh Shilimkar --- drivers/dma/o