RE: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag

2015-09-18 Thread Alonso Adrian
ger.kernel.org; Li > Frank-B20596 ; Garg Nitin-B37173 > ; Huang Yongcai-B20788 > ; linux-g...@vger.kernel.org; > robh...@kernel.org; Gong Yibin-B38343 > Subject: Re: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID > flag > > On Tue, Sep 08, 2015 at 04:05:32P

Re: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag

2015-09-18 Thread Shawn Guo
On Tue, Sep 08, 2015 at 04:05:32PM +, Alonso Adrian wrote: > Hi Shawn, > > See comments below Please use bottom posting, not top posting. ... > > @@ -536,21 +536,29 @@ static int imx_pinctrl_parse_groups(struct > > device_node *np, > > return -ENOMEM; > > > > for (i = 0

Re: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag

2015-09-08 Thread Alonso Adrian
@vger.kernel.org; Li Frank-B20596; Garg Nitin-B37173; Huang Yongcai-B20788; linux-g...@vger.kernel.org; robh...@kernel.org; Gong Yibin-B38343 Subject: Re: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag On Tue, Sep 01, 2015 at 05:49:10PM -0500, Adrian Alonso wrote: > -

Re: [PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag

2015-09-06 Thread Shawn Guo
On Tue, Sep 01, 2015 at 05:49:10PM -0500, Adrian Alonso wrote: > - Add ZERO_OFFSET_VALID flag, on imx7d mux_conf reg > offset is zero for iomuxc-lspr controller > - Do default initialization on parse group function. > > Signed-off-by: Adrian Alonso I do not follow why this patch is needed at a

[PATCH v2 5/8] pinctrl: freescale: imx: add ZERO_OFFSET_VALID flag

2015-09-01 Thread Adrian Alonso
- Add ZERO_OFFSET_VALID flag, on imx7d mux_conf reg offset is zero for iomuxc-lspr controller - Do default initialization on parse group function. Signed-off-by: Adrian Alonso --- Changes for V2: Resend drivers/pinctrl/freescale/pinctrl-imx.c | 23 +-- drivers/pinctrl/free