Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Daniel Vetter
On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: On 2014年09月20日 08:03, Rob Clark wrote: On Fri, Sep 19, 2014 at 1:47 AM, Mark yao mark@rock-chips.com wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h new file mode 100644 index

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-23 Thread Mark yao
On 2014年09月23日 15:48, Daniel Vetter wrote: On Mon, Sep 22, 2014 at 09:32:19AM +0800, Mark yao wrote: On 2014年09月20日 08:03, Rob Clark wrote: On Fri, Sep 19, 2014 at 1:47 AM, Mark yao mark@rock-chips.com wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-21 Thread Mark yao
On 2014年09月19日 21:04, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 7:47 AM, Mark yao mark@rock-chips.com wrote: [snip] +static int rockchip_drm_bind(struct device *dev) +{ + return drm_platform_init(rockchip_drm_driver, to_platform_device(dev)); Please avoid drm_platform_*()

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-21 Thread Mark yao
On 2014年09月20日 08:03, Rob Clark wrote: On Fri, Sep 19, 2014 at 1:47 AM, Mark yao mark@rock-chips.com wrote: diff --git a/include/uapi/drm/rockchip_drm.h b/include/uapi/drm/rockchip_drm.h new file mode 100644 index 000..8f8e60e --- /dev/null +++ b/include/uapi/drm/rockchip_drm.h @@ -0,0

Re: [PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 7:47 AM, Mark yao mark@rock-chips.com wrote: [snip] +static int rockchip_drm_bind(struct device *dev) +{ + return drm_platform_init(rockchip_drm_driver, to_platform_device(dev)); Please avoid drm_platform_*() usage. We're about to drop all the drm_bus

[PATCH v3 1/5] drm/rockchip: Add basic drm driver

2014-09-18 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao mark@rock-chips.com --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma