Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-01 Thread Chanwoo Choi
Hi Roger, On 01/30/2015 11:03 PM, Roger Quadros wrote: > On 30/01/15 02:11, Chanwoo Choi wrote: >> Hi Roger, >> >> On 01/28/2015 09:15 PM, Roger Quadros wrote: >>> This driver observes the USB ID pin connected over a GPIO and >>> updates the USB cable extcon states accordingly. >>> >>> The existin

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
On 30/01/15 02:11, Chanwoo Choi wrote: > Hi Roger, > > On 01/28/2015 09:15 PM, Roger Quadros wrote: >> This driver observes the USB ID pin connected over a GPIO and >> updates the USB cable extcon states accordingly. >> >> The existing GPIO extcon driver is not suitable for this purpose >> as it n

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
+Thomas (for irq/dummychip.c question) Hi, On 30/01/15 13:09, Roger Quadros wrote: > Chanwoo, > > On 30/01/15 02:06, Chanwoo Choi wrote: >> Hi Roger, >> >> On 01/29/2015 08:26 PM, Roger Quadros wrote: >>> Chanwoo, >>> >>> On 29/01/15 03:49, Chanwoo Choi wrote: Hi Roger, We need to

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
Chanwoo, On 30/01/15 02:06, Chanwoo Choi wrote: > Hi Roger, > > On 01/29/2015 08:26 PM, Roger Quadros wrote: >> Chanwoo, >> >> On 29/01/15 03:49, Chanwoo Choi wrote: >>> Hi Roger, >>> >>> We need to discuss one point about 'id_irqwake'. >>> I don't recommend to use 'id_irqwake' field. >>> >>> And

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
Hi Roger, On 01/28/2015 09:15 PM, Roger Quadros wrote: > This driver observes the USB ID pin connected over a GPIO and > updates the USB cable extcon states accordingly. > > The existing GPIO extcon driver is not suitable for this purpose > as it needs to be taught to understand USB cable states

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
Hi Roger, On 01/29/2015 08:26 PM, Roger Quadros wrote: > Chanwoo, > > On 29/01/15 03:49, Chanwoo Choi wrote: >> Hi Roger, >> >> We need to discuss one point about 'id_irqwake'. >> I don't recommend to use 'id_irqwake' field. >> >> And I catch build warning by using "select" keywork in Kconfig. >>

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Roger Quadros
Chanwoo, On 29/01/15 03:49, Chanwoo Choi wrote: > Hi Roger, > > We need to discuss one point about 'id_irqwake'. > I don't recommend to use 'id_irqwake' field. > > And I catch build warning by using "select" keywork in Kconfig. > It is my wrong guide of "select" keyword. So, I'll change it > as

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Chanwoo Choi
Hi Roger, We need to discuss one point about 'id_irqwake'. I don't recommend to use 'id_irqwake' field. And I catch build warning by using "select" keywork in Kconfig. It is my wrong guide of "select" keyword. So, I'll change it as 'depends on' keyword. Looks good to me except for 'id_irqwake'.

[PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Roger Quadros
This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be taught to understand USB cable states and it can't handle more than one cable per instance. For the USB