Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

2015-03-24 Thread Joe Perches
On Tue, 2015-03-24 at 23:05 +, Srinivas Kandagatla wrote: > On 24/03/15 22:36, Mark Brown wrote: > >> +int regmap_get_max_register(struct regmap *map) > >> +{ > >> + return map->max_register ? : -EINVAL; > >> +} > > > > Please write the logic out properly, don't abuse the ternery operator. > A

Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

2015-03-24 Thread Srinivas Kandagatla
On 24/03/15 22:36, Mark Brown wrote: On Tue, Mar 24, 2015 at 10:29:39PM +, Srinivas Kandagatla wrote: This patch introduces regmap_get_max_register() function which would be used by the infrastructures like eeprom framework built on top of regmap. In what way would it be used? Its used

Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

2015-03-24 Thread Mark Brown
On Tue, Mar 24, 2015 at 10:29:39PM +, Srinivas Kandagatla wrote: > This patch introduces regmap_get_max_register() function which would be > used by the infrastructures like eeprom framework built on top of > regmap. In what way would it be used? > +int regmap_get_max_register(struct regmap

[PATCH v3 1/9] regmap: Introduce regmap_get_max_register.

2015-03-24 Thread Srinivas Kandagatla
This patch introduces regmap_get_max_register() function which would be used by the infrastructures like eeprom framework built on top of regmap. Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap.c | 12 include/linux/regmap.h | 7 +++ 2 files changed, 19