Lee Jones writes:
> Very well, Russell and yourself have convinced me. If you fixup the
> remainder of comments, I'm happy.
Cool.
Let me a couple of days to gather my wits, cross-check I have not forgotten a
comment, make some testing on the board and then post v4.
Cheers.
--
Robert
--
To uns
On Wed, Jan 21, 2015 at 08:40:44AM -0800, Joe Perches wrote:
> On Wed, 2015-01-21 at 16:11 +, Russell King - ARM Linux wrote:
> > On Wed, Jan 21, 2015 at 08:05:21AM -0800, Joe Perches wrote:
> > > (adding netdev)
> >
> > I wasn't actually reporting that as an issue; I was using it as an
> > ex
On Wed, 2015-01-21 at 16:11 +, Russell King - ARM Linux wrote:
> On Wed, Jan 21, 2015 at 08:05:21AM -0800, Joe Perches wrote:
> > (adding netdev)
>
> I wasn't actually reporting that as an issue; I was using it as an
> example. It's from a very old kernel (2.6.27.21) which I run on one
> of m
On Wed, Jan 21, 2015 at 08:05:21AM -0800, Joe Perches wrote:
> (adding netdev)
I wasn't actually reporting that as an issue; I was using it as an
example. It's from a very old kernel (2.6.27.21) which I run on one
of my old x86 machines.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps
(adding netdev)
On Wed, 2015-01-21 at 09:44 +, Russell King - ARM Linux wrote:
> On Wed, Jan 21, 2015 at 08:46:29AM +0100, Robert Jarzmik wrote:
> > Russell King - ARM Linux writes:
> >
> > > What I'd suggest (and always have done) is:
> > >
> > > dev_err(&pdev->dev, "couldn't request main
On Wed, 21 Jan 2015, robert.jarz...@free.fr wrote:
> > - Mail original -
> > De: "Lee Jones"
> First of all, this is my web mail interface, so please be kind with
> my mail formatting ...
I have no idea what you want me to change or do differently?
Perhaps it might be more prudent for y
> - Mail original -
> De: "Lee Jones"
First of all, this is my web mail interface, so please be kind with
my mail formatting ...
> Looking at one of the other patches in the series it appears the flag
> you're trying to capture is IORESOURCE_IRQ_LOWEDGE. When I grep for
> where this is b
On Wed, Jan 21, 2015 at 12:35:51PM +, Lee Jones wrote:
> I think to set an edge trigger on an IRQ, you should instead do so via
> irq_set_irq_type(), or have a missed a line or two?
Setting the IRQ type in request_irq() is perfectly acceptable.
include/linux/interrupt.h:
/*
* These correspon
On Wed, 21 Jan 2015, Robert Jarzmik wrote:
> Lee Jones writes:
>
> > On Wed, 21 Jan 2015, Robert Jarzmik wrote:
> >> > > > platform_get_irq()?
> >> > > No. I need the flags.
> >> > Where are they used?
> >> A couple of lines below, using local "irqflags" variable :
> >>ret = devm_request
On Wed, Jan 21, 2015 at 08:16:45AM +, Lee Jones wrote:
> On Wed, 21 Jan 2015, Robert Jarzmik wrote:
> > > > > platform_get_irq()?
> > > > No. I need the flags.
> > > Where are they used?
> > A couple of lines below, using local "irqflags" variable :
> >ret = devm_request_irq(&pdev->dev,
On Wed, Jan 21, 2015 at 08:46:29AM +0100, Robert Jarzmik wrote:
> Russell King - ARM Linux writes:
>
> > What I'd suggest (and always have done) is:
> >
> > dev_err(&pdev->dev, "couldn't request main irq%d: %d\n",
> > irq, ret);
> I like it, it's even more compact, I'll use it for
Lee Jones writes:
> On Wed, 21 Jan 2015, Robert Jarzmik wrote:
>> > > > platform_get_irq()?
>> > > No. I need the flags.
>> > Where are they used?
>> A couple of lines below, using local "irqflags" variable :
>>ret = devm_request_irq(&pdev->dev, cot->irq, lubbock_irq_handler,
>>
On Wed, 21 Jan 2015, Robert Jarzmik wrote:
> > > > platform_get_irq()?
> > > No. I need the flags.
> > Where are they used?
> A couple of lines below, using local "irqflags" variable :
>ret = devm_request_irq(&pdev->dev, cot->irq, lubbock_irq_handler,
> irqflag
Russell King - ARM Linux writes:
> What I'd suggest (and always have done) is:
>
> dev_err(&pdev->dev, "couldn't request main irq%d: %d\n",
> irq, ret);
I like it, it's even more compact, I'll use it for next patch version.
> but I guess printing the IRQ number no longer make
On Tue, Jan 20, 2015 at 10:29:19AM +, Lee Jones wrote:
> On Mon, 19 Jan 2015, Robert Jarzmik wrote:
> > >> +if (ret) {
> > >> +dev_err(&pdev->dev, "Couldn't request main irq : ret =
> > >> %d\n",
> > >> +ret);
> > >
> > > I'm not keen on this typ
On Mon, 19 Jan 2015, Robert Jarzmik wrote:
> Lee Jones writes:
> > On Fri, 16 Jan 2015, Robert Jarzmik wrote:
[...]
> >> + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> >
> > platform_get_irq()?
> No. I need the flags.
Where are they used?
[...]
> >> + if (ret) {
> >> + d
Lee Jones writes:
> On Fri, 16 Jan 2015, Robert Jarzmik wrote:
>
>> As a fix, move the gpio0 chained handler setup to a place where we have
>> the guarantee that pxa_gpio_probe() was called before, so that lubbock
>> handler becomes the true IRQ chained handler of GPIO0, demuxing the
>> lubbock I
On Fri, 16 Jan 2015, Robert Jarzmik wrote:
> Lubbock () board is the IO motherboard of the Intel PXA25x Development
> Platform, which supports the Lubbock pxa25x soc board.
>
> Historically, this support was in arch/arm/mach-pxa/lubbock.c. When
> gpio-pxa was moved to drivers/pxa, it became a dri
Lubbock () board is the IO motherboard of the Intel PXA25x Development
Platform, which supports the Lubbock pxa25x soc board.
Historically, this support was in arch/arm/mach-pxa/lubbock.c. When
gpio-pxa was moved to drivers/pxa, it became a driver, and its
initialization and probing happened at po
19 matches
Mail list logo
