Re: [PATCH v3 2/3] net: Add Keystone NetCP ethernet driver

2014-09-25 Thread Santosh Shilimkar
On Wednesday 24 September 2014 04:43 PM, David Miller wrote: > From: Santosh Shilimkar > Date: Wed, 24 Sep 2014 15:51:15 -0400 > >> Here is an updated version with above fixed. Not posting the entire >> series again since its just small update on the patch. > > That's not how this works. > > If

Re: [PATCH v3 2/3] net: Add Keystone NetCP ethernet driver

2014-09-24 Thread David Miller
From: Santosh Shilimkar Date: Wed, 24 Sep 2014 15:51:15 -0400 > Here is an updated version with above fixed. Not posting the entire > series again since its just small update on the patch. That's not how this works. If you want your changes re-reviewed and considered for real inclusion, you mus

Re: [PATCH v3 2/3] net: Add Keystone NetCP ethernet driver

2014-09-16 Thread Sandeep Nair
On 9/15/2014 12:37 PM, David Miller wrote: From: Santosh Shilimkar Date: Sat, 13 Sep 2014 16:07:18 -0400 + /* Find this module in the sub-tree for this device */ + devices = of_get_child_by_name(node, "netcp-devices"); + if (!devices) { + dev_err(dev, "could not

Re: [PATCH v3 2/3] net: Add Keystone NetCP ethernet driver

2014-09-15 Thread David Miller
From: Santosh Shilimkar Date: Sat, 13 Sep 2014 16:07:18 -0400 > + /* Find this module in the sub-tree for this device */ > + devices = of_get_child_by_name(node, "netcp-devices"); > + if (!devices) { > + dev_err(dev, "could not find netcp-devices node\n"); > +