Re: [PATCH v3 4/5] pci: designware: remove pci_common_init_dev()

2015-05-25 Thread Fabrice Gasnier
Hi Bjorn, On 05/06/2015 09:22 PM, Bjorn Helgaas wrote: It's not completely obvious that replacing pci_common_init_dev() with dw_pcie_setup() is equivalent. Here are my notes from trying to convince myself that this is correct. I think your changelog could stand some enhancement. It would be i

Re: [PATCH v3 4/5] pci: designware: remove pci_common_init_dev()

2015-05-06 Thread Bjorn Helgaas
On Fri, Apr 10, 2015 at 11:12:47AM +0200, Gabriel FERNANDEZ wrote: > Call directly pci_*() instead of using pci_common_init_dev(). > Enforce error handling in probe. > It also allows st pcie driver not to declare IO space: > pci_common_init_dev() is assigning one by default. Can you verify that no