On Mon, Sep 28, 2015 at 09:58:44AM +0200, Jacek Anaszewski wrote:
> Hi Rob.
>
> If you are satisfied with Simon's explanation, could you confirm
> that with your ack, please?
Hi Rob,
Please let us know your answer.
Thanks in advance.
Simon
> On 09/22/2015 11:30 AM, Simon Guinot wrote:
> >On M
Hi Rob.
If you are satisfied with Simon's explanation, could you confirm that
with your ack, please?
Best Regards,
Jacek Anaszewski
On 09/22/2015 11:30 AM, Simon Guinot wrote:
On Mon, Sep 21, 2015 at 10:38:45AM -0500, Rob Herring wrote:
Hi Rob,
Thanks for your feedback. Please, see my answ
On Mon, Sep 21, 2015 at 10:38:45AM -0500, Rob Herring wrote:
Hi Rob,
Thanks for your feedback. Please, see my answers below.
> On 09/17/2015 10:59 AM, Simon Guinot wrote:
> > This patch adds device tree support for the netxbig LEDs.
> >
> > This also introduces a additionnal DT binding for the
On 09/17/2015 10:59 AM, Simon Guinot wrote:
> This patch adds device tree support for the netxbig LEDs.
>
> This also introduces a additionnal DT binding for the GPIO extension bus
> (netxbig-gpio-ext) used to configure the LEDs. Since this bus could also
> be used to control other devices, then i
On 09/18/2015 03:10 PM, Simon Guinot wrote:
On Fri, Sep 18, 2015 at 12:49:28PM +0200, Jacek Anaszewski wrote:
Moreover, if you switched to using devm* prefixed version of
gpio_request_one and led_classdev_reqister, you could simplify
the error paths in the driver.
Yes, I have a pending patch
On Fri, Sep 18, 2015 at 12:49:28PM +0200, Jacek Anaszewski wrote:
> >>
> >>Moreover, if you switched to using devm* prefixed version of
> >>gpio_request_one and led_classdev_reqister, you could simplify
> >>the error paths in the driver.
> >
> >Yes, I have a pending patch for this conversion. But s
On 09/18/2015 12:30 PM, Simon Guinot wrote:
On Fri, Sep 18, 2015 at 11:16:41AM +0200, Jacek Anaszewski wrote:
Hi Simon,
Please find my comments in the code below.
Hi Jacek,
Thanks for the quick review.
You're welcome.
On 09/17/2015 05:59 PM, Simon Guinot wrote:
This patch adds device t
On Fri, Sep 18, 2015 at 11:16:41AM +0200, Jacek Anaszewski wrote:
> Hi Simon,
>
> Please find my comments in the code below.
Hi Jacek,
Thanks for the quick review.
>
> On 09/17/2015 05:59 PM, Simon Guinot wrote:
> >This patch adds device tree support for the netxbig LEDs.
> >
> >This also intr
Hi Simon,
Please find my comments in the code below.
On 09/17/2015 05:59 PM, Simon Guinot wrote:
This patch adds device tree support for the netxbig LEDs.
This also introduces a additionnal DT binding for the GPIO extension bus
(netxbig-gpio-ext) used to configure the LEDs. Since this bus coul
This patch adds device tree support for the netxbig LEDs.
This also introduces a additionnal DT binding for the GPIO extension bus
(netxbig-gpio-ext) used to configure the LEDs. Since this bus could also
be used to control other devices, then it seems more suitable to have it
in a separate DT bind
10 matches
Mail list logo
