Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-02 Thread Krzysztof Kozlowski
On 03.11.2015 15:58, Pavel Fedin wrote: > Hello! > > --- cut exynos5410.dtsi --- > sromc: sromc@1225 { > #address-cells = <2>; > #size-cells = <1>; > ranges = <0 0 0x0400 0x2 >

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-02 Thread Pavel Fedin
Hello! > >>> --- cut exynos5410.dtsi --- > >>> sromc: sromc@1225 { > >>> #address-cells = <2>; > >>> #size-cells = <1>; > >>> ranges = <0 0 0x0400 0x2 > >>> 1 0 0x0500 0x2 > >>>

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-02 Thread Krzysztof Kozlowski
On 02.11.2015 16:31, Pavel Fedin wrote: > Hello! > >>> --- cut exynos5410.dtsi --- >>> sromc: sromc@1225 { >>> #address-cells = <2>; >>> #size-cells = <1>; >>> ranges = <0 0 0x0400 0x2 >>>

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-01 Thread Krzysztof Kozlowski
W dniu 30.10.2015 o 19:43, Pavel Fedin pisze: > Hello! > >> Please, carefully look at: >> Documentation/devicetree/bindings/net/gpmc-eth.txt >> Documentation/devicetree/bindings/bus/ti-gpmc.txt >> >> 1. Try to re-use existing bindings. Although I see existing bank-width >> and gpmc,device-width

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-01 Thread Krzysztof Kozlowski
W dniu 31.10.2015 o 02:15, Rob Herring pisze: > On Fri, Oct 30, 2015 at 2:23 AM, Krzysztof Kozlowski > wrote: >> On 30.10.2015 15:58, Pavel Fedin wrote: >>> Hello! >>> > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-01 Thread Pavel Fedin
Hello! > > --- cut exynos5410.dtsi --- > > sromc: sromc@1225 { > > #address-cells = <2>; > > #size-cells = <1>; > > ranges = <0 0 0x0400 0x2 > > 1 0 0x0500 0x2 > >

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Krzysztof Kozlowski
On 29.10.2015 21:42, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. Please, carefully look at: Documentation/devicetree/bindings/net/gpmc-eth.txt

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Pavel Fedin
Hello! > > Add documentation for new subnode properties, allowing bank configuration. > > Based on u-boot implementation, but heavily reworked. > > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt Thank you

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Krzysztof Kozlowski
On 30.10.2015 15:58, Pavel Fedin wrote: > Hello! > >>> Add documentation for new subnode properties, allowing bank configuration. >>> Based on u-boot implementation, but heavily reworked. >> >> Please, carefully look at: >> Documentation/devicetree/bindings/net/gpmc-eth.txt >>

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Pavel Fedin
Hello! > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt > > 1. Try to re-use existing bindings. Although I see existing bank-width > and gpmc,device-width but yours samsung,srom-data-width seems better. > Maybe

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Rob Herring
On Fri, Oct 30, 2015 at 2:23 AM, Krzysztof Kozlowski wrote: > On 30.10.2015 15:58, Pavel Fedin wrote: >> Hello! >> Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. >>> >>> Please,

[PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 Thread Pavel Fedin
Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. Signed-off-by: Pavel Fedin --- .../bindings/arm/samsung/exynos-srom.txt | 50 +- 1 file changed, 48 insertions(+),