Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-18 Thread Sebastian Andrzej Siewior
On Wed, Jun 17, 2015 at 03:02:03PM +0200, Stefan Agner wrote: > On 2015-06-09 22:07, Sebastian Andrzej Siewior wrote: > > yeah, do you have any numbers by chance? > > Just reevaluated the "performance optimizations". On a VF610 SoC (with > L2 cache) the improvements increase performance by 2.5% an

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-17 Thread Stefan Agner
On 2015-06-09 22:07, Sebastian Andrzej Siewior wrote: > On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote: >> As Boris guessed correctly, the reason I used the raw variant was due to >> performance improvements due to the barrier. However, I will use > > yeah, do you have any numbers by chance? >

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-12 Thread Sebastian Andrzej Siewior
On 2015-06-09 22:31:07 [+0200], Stefan Agner wrote: > > have the endian swap. So an abstraction like you provided earlier > > would be nice :) > > What do you mean by that? Something like you did for the reader where you have: |static inline u32 vf610_nfc_read(struct vf610_nfc *nfc, uint reg) |{

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-09 Thread Stefan Agner
On 2015-06-09 22:07, Sebastian Andrzej Siewior wrote: > On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote: >> As Boris guessed correctly, the reason I used the raw variant was due to >> performance improvements due to the barrier. However, I will use > > yeah, do you have any numbers by chance?

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-09 Thread Sebastian Andrzej Siewior
On 2015-06-03 17:05:16 [+0200], Stefan Agner wrote: > As Boris guessed correctly, the reason I used the raw variant was due to > performance improvements due to the barrier. However, I will use yeah, do you have any numbers by chance? > {read|write}l_relaxed instead, which should offer endian abs

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-09 Thread Sebastian Andrzej Siewior
On 2015-06-03 17:09:33 [+0200], Stefan Agner wrote: > Hm, so on PPC the boot ROM is making use of the HW ECC controller, is > this correct? On MPC5125, yes. > -- > Stefan Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Stefan Agner
On 2015-06-03 15:08, Sebastian Andrzej Siewior wrote: > On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: >> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c >> new file mode 100644 >> index 000..23c1510 >> --- /dev/null >> +++ b/drivers/mtd/nand/vf610_nfc.c >> @@ -0,0

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Stefan Agner
On 2015-06-03 14:03, Sebastian Andrzej Siewior wrote: > On Wed, Jun 03, 2015 at 11:45:50AM +0200, Stefan Agner wrote: >> On 2015-06-03 10:10, Sebastian Andrzej Siewior wrote: >> > On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: >> >> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Sebastian Andrzej Siewior
On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > new file mode 100644 > index 000..23c1510 > --- /dev/null > +++ b/drivers/mtd/nand/vf610_nfc.c > @@ -0,0 +1,686 @@ … > +static inline u32 vf610_nfc_read(struct vf610_

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Sebastian Andrzej Siewior
On Wed, Jun 03, 2015 at 11:45:50AM +0200, Stefan Agner wrote: > On 2015-06-03 10:10, Sebastian Andrzej Siewior wrote: > > On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: > >> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > >> new file mode 100644 > >> index 000..2

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Stefan Agner
On 2015-06-03 10:10, Sebastian Andrzej Siewior wrote: > On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: >> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c >> new file mode 100644 >> index 000..23c1510 >> --- /dev/null >> +++ b/drivers/mtd/nand/vf610_nfc.c > … >> +st

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-03 Thread Sebastian Andrzej Siewior
On 2015-03-25 17:28:24 [+0100], Stefan Agner wrote: > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > new file mode 100644 > index 000..23c1510 > --- /dev/null > +++ b/drivers/mtd/nand/vf610_nfc.c … > +static void vf610_nfc_addr_cycle(struct vf610_nfc *nfc, int column

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-02 Thread Stefan Agner
Hi Brian, Thanks for the review! FYI, in between I have some patches pending which enable ONFI and some other minor improvements. Those changes already went upstream in U-Boot, I will port them to the Linux version. Hence the next version will also include those changes... FWIW, the U-boot thre

Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-06-01 Thread Brian Norris
Hi Stefan, Late review... On Wed, Mar 25, 2015 at 05:28:24PM +0100, Stefan Agner wrote: > This driver supports Freescale NFC (NAND flash controller) found on > Vybrid (VF610), MPC5125, MCF54418 and Kinetis K70. > > Limitations: > - DMA and pipelining not used > - Pages larger than 2k are not sup

[PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

2015-03-25 Thread Stefan Agner
This driver supports Freescale NFC (NAND flash controller) found on Vybrid (VF610), MPC5125, MCF54418 and Kinetis K70. Limitations: - DMA and pipelining not used - Pages larger than 2k are not supported - No hardware ECC The driver has only been tested on Vybrid (VF610). Signed-off-by: Bill Prin