Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-11-04 Thread Julian Calaby
Hi Maxime, On Thu, Nov 5, 2015 at 3:23 AM, Maxime Ripard wrote: > Hi Julian, > > On Wed, Oct 28, 2015 at 10:12:09AM +1100, Julian Calaby wrote: >> > + of_property_for_each_u32(node, "clock-indices", prop, p, index) { >> > +

Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-11-04 Thread Maxime Ripard
Hi Julian, On Wed, Oct 28, 2015 at 10:12:09AM +1100, Julian Calaby wrote: > > + of_property_for_each_u32(node, "clock-indices", prop, p, index) { > > + of_property_read_string_index(node, "clock-output-names", > > + i, _name); > > +

Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-11-04 Thread Maxime Ripard
Hi Arnd, On Fri, Oct 30, 2015 at 09:28:55AM +0100, Arnd Bergmann wrote: > On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote: > > + of_property_read_string_index(node, "clock-output-names", > > + i, _name); > > + > > + if

Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-11-01 Thread Jens Kuske
Hi, On 30/10/15 09:28, Arnd Bergmann wrote: > On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote: >> + of_property_read_string_index(node, "clock-output-names", >> + i, _name); >> + >> + if (index == 17 || (index >= 29 &&

Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-10-30 Thread Arnd Bergmann
On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote: > + of_property_read_string_index(node, "clock-output-names", > + i, _name); > + > + if (index == 17 || (index >= 29 && index <= 31)) > + clk_parent =

[PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-10-27 Thread Jens Kuske
The H3 clock control unit is similar to the those of other sun8i family members like the A23. It adds a new bus gates clock similar to the simple gates, but with a different parent clock for each single gate. Some of the gates use the new AHB2 clock as parent, whose clock source is muxable

Re: [linux-sunxi] [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

2015-10-27 Thread Julian Calaby
Hi Jens, On Wed, Oct 28, 2015 at 3:50 AM, Jens Kuske wrote: > The H3 clock control unit is similar to the those of other sun8i family > members like the A23. > > It adds a new bus gates clock similar to the simple gates, but with a > different parent clock for each single