Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-18 Thread Mark Brown
On Sun, Jan 18, 2015 at 04:29:02PM +0100, Hans de Goede wrote: > On 18-01-15 13:35, Mark Brown wrote: > >Right, but that's not what regulator-boot-on actually means (and I'm not > >sure why you would think it would TBH) > Well, the meaning of regulator-boot-on is not clearly defined really, to >

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-18 Thread Hans de Goede
Hi, On 18-01-15 13:35, Mark Brown wrote: On Sat, Jan 17, 2015 at 03:28:39PM +0100, Hans de Goede wrote: On 17-01-15 14:14, Mark Brown wrote: Following your argument to the logical conclusion means we can never turn any regualtor off - we always have the risk that there's another shared user

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-18 Thread Mark Brown
On Sat, Jan 17, 2015 at 03:28:39PM +0100, Hans de Goede wrote: > On 17-01-15 14:14, Mark Brown wrote: > >Following your argument to the logical conclusion means we can never > >turn any regualtor off - we always have the risk that there's another > >shared user which is going to get a power bounce

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-17 Thread Hans de Goede
Hi, On 17-01-15 14:14, Mark Brown wrote: On Sat, Jan 17, 2015 at 09:48:57AM +0100, Hans de Goede wrote: and leave these regulators on, rather then turn them of $random time, because as I've advocated before (see the simplefb thread) there is no simple magic moment when it is right to turn thin

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-17 Thread Mark Brown
On Sat, Jan 17, 2015 at 09:48:57AM +0100, Hans de Goede wrote: > and leave these regulators on, rather then turn them of $random time, > because as I've advocated before (see the simplefb thread) there is > no simple magic moment when it is right to turn things off, so doing > it when userspace st

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-17 Thread Hans de Goede
Hi, On 16-01-15 21:25, Mark Brown wrote: On Fri, Jan 16, 2015 at 08:12:28PM +0100, Hans de Goede wrote: On 16-01-15 13:37, Mark Brown wrote: It is probably a good idea to use regulator-boot-on and then test things this way, and if that works use regulator-boot-on. No, it's unlikely that b

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Mark Brown
On Fri, Jan 16, 2015 at 08:12:28PM +0100, Hans de Goede wrote: > On 16-01-15 13:37, Mark Brown wrote: > >>It is probably a good idea to use regulator-boot-on and > >>then test things this way, and if that works use > >>regulator-boot-on. > >No, it's unlikely that boot-on makes sense here - it's t

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Mark Brown
On Fri, Jan 16, 2015 at 08:13:36PM +0100, Hans de Goede wrote: > On 16-01-15 16:34, Mark Brown wrote: > >>As pointed by Hans my concern here was be sure that during boot the disk > >>are not power off. In this case which property would be accurate? > >None, the core won't do anything with the reg

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 16:34, Mark Brown wrote: On Fri, Jan 16, 2015 at 03:27:00PM +0100, Gregory CLEMENT wrote: On 16/01/2015 13:37, Mark Brown wrote: regulator-always-on is a bit fuzzy for suspend, if the regulator has suspend control it'll kick in - it's really about the Linux refcounting while

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 13:37, Mark Brown wrote: On Fri, Jan 16, 2015 at 11:10:18AM +0100, Hans de Goede wrote: On 16-01-15 10:27, Gregory CLEMENT wrote: + reg_sata0: pwr-sata0 { + compatible = "regulator-fixed"; + regulator-name = "pwr_en_sata0"; + en

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Mark Brown
On Fri, Jan 16, 2015 at 03:27:00PM +0100, Gregory CLEMENT wrote: > On 16/01/2015 13:37, Mark Brown wrote: > > regulator-always-on is a bit fuzzy for suspend, if the regulator has > > suspend control it'll kick in - it's really about the Linux refcounting > > while it's running. What's more concer

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Gregory CLEMENT
Hi Mark and Hans, On 16/01/2015 13:37, Mark Brown wrote: > On Fri, Jan 16, 2015 at 11:10:18AM +0100, Hans de Goede wrote: >> On 16-01-15 10:27, Gregory CLEMENT wrote: > > + reg_sata0: pwr-sata0 { > + compatible = "regulator-fixed"; > + regulator-name = "pwr_en_sata0";

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Mark Brown
On Fri, Jan 16, 2015 at 11:10:18AM +0100, Hans de Goede wrote: > On 16-01-15 10:27, Gregory CLEMENT wrote: > >>>+ reg_sata0: pwr-sata0 { > >>>+ compatible = "regulator-fixed"; > >>>+ regulator-name = "pwr_en_sata0"; > >>>+ enable-active-high; > >>>+ regulator-a

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 16-01-15 10:27, Gregory CLEMENT wrote: Hi Hans, On 16/01/2015 09:17, Hans de Goede wrote: Hi, On 15-01-15 15:09, Gregory CLEMENT wrote: Add the regulators to each SATA port. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-gp.dts | 126

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Gregory CLEMENT
Hi Hans, On 16/01/2015 09:17, Hans de Goede wrote: > Hi, > > On 15-01-15 15:09, Gregory CLEMENT wrote: >> Add the regulators to each SATA port. >> >> Signed-off-by: Gregory CLEMENT >> --- >> arch/arm/boot/dts/armada-388-gp.dts | 126 >> >> 1 file changed,

Re: [PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-16 Thread Hans de Goede
Hi, On 15-01-15 15:09, Gregory CLEMENT wrote: Add the regulators to each SATA port. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-gp.dts | 126 1 file changed, 126 insertions(+) diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/

[PATCH v4 4/4] ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

2015-01-15 Thread Gregory CLEMENT
Add the regulators to each SATA port. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-388-gp.dts | 126 1 file changed, 126 insertions(+) diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts index 4df22bf91683..