Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-12-03 Thread Mark Brown
On Mon, Dec 02, 2013 at 03:12:35PM +0100, Krzysztof Kozlowski wrote: > Do you wish me to change the patch to previous version using > of_get_child_by_name()? It'd be more standard, yes. signature.asc Description: Digital signature

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-12-02 Thread Krzysztof Kozlowski
Hi Mark, On Wed, 2013-11-27 at 16:28 +, Mark Brown wrote: > On Wed, Nov 27, 2013 at 04:13:23PM +, Lee Jones wrote: > > On Wed, 27 Nov 2013, Mark Brown wrote: > > > > The usual thing to do is of_get_child_by_name() on the parent to get the > > > container to search in. > > > What do you m

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Mark Brown
On Wed, Nov 27, 2013 at 04:13:23PM +, Lee Jones wrote: > On Wed, 27 Nov 2013, Mark Brown wrote: > > The usual thing to do is of_get_child_by_name() on the parent to get the > > container to search in. > What do you mean when you say 'usual thing'? Only the max8998 does > this currently. IMHO

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Lee Jones
On Wed, 27 Nov 2013, Mark Brown wrote: > On Wed, Nov 27, 2013 at 03:23:58PM +, Lee Jones wrote: > > On Wed, 27 Nov 2013, Mark Brown wrote: > > > > + { > > > > + .name = "max14577-regulator", > > > > + .of_compatible = "maxim,max14577-regulator", > > > > +

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Mark Brown
On Wed, Nov 27, 2013 at 03:23:58PM +, Lee Jones wrote: > On Wed, 27 Nov 2013, Mark Brown wrote: > > > + { > > > + .name = "max14577-regulator", > > > + .of_compatible = "maxim,max14577-regulator", > > > + }, > > Why is there a compatible for this at all, would this ever appear

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Lee Jones
On Wed, 27 Nov 2013, Mark Brown wrote: > On Wed, Nov 27, 2013 at 02:46:21PM +0100, Krzysztof Kozlowski wrote: > > > + { > > + .name = "max14577-regulator", > > + .of_compatible = "maxim,max14577-regulator", > > + }, > > Why is there a compatible for this at all, would thi

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Mark Brown
On Wed, Nov 27, 2013 at 02:46:21PM +0100, Krzysztof Kozlowski wrote: > + { > + .name = "max14577-regulator", > + .of_compatible = "maxim,max14577-regulator", > + }, Why is there a compatible for this at all, would this ever appear as part of a different device? s

Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Lee Jones
On Wed, 27 Nov 2013, Krzysztof Kozlowski wrote: > MAX14577 chip is a multi-function device which includes MUIC, > charger and voltage regulator. The driver is located in drivers/mfd. > > This patch adds regulator driver for MAX14577 chip. There are two > regulators in this chip: > 1. Safeout LDO

[PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577

2013-11-27 Thread Krzysztof Kozlowski
MAX14577 chip is a multi-function device which includes MUIC, charger and voltage regulator. The driver is located in drivers/mfd. This patch adds regulator driver for MAX14577 chip. There are two regulators in this chip: 1. Safeout LDO with constant voltage output of 4.9V. It can be only enabl