Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 11 December 2014 01:14 PM, Yunzhi Li wrote: Hi Kishon: On 2014/12/11 14:02, Kishon Vijay Abraham I wrote: Hi, On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288.

[PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Yunzhi Li
This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF (general register files) module. Signed-off-by: Yunzhi Li

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all configured through a set of registers located in the GRF

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Joe Perches
On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote: On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c [] +/* + * The higher 16-bit of this register is used for write protection + * only if

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Kishon Vijay Abraham I
Hi, On Thursday 11 December 2014 11:42 AM, Joe Perches wrote: On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote: On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c [] +/* + * The higher 16-bit

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Joe Perches
On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote: Hi, On Thursday 11 December 2014 11:42 AM, Joe Perches wrote: On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote: On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: diff --git

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Yunzhi Li
On 2014/12/11 14:37, Joe Perches wrote: On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote: Hi, On Thursday 11 December 2014 11:42 AM, Joe Perches wrote: On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote: On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Joe Perches
On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote: On 2014/12/11 14:37, Joe Perches wrote: On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote: [] So If I have to write something on bit 0, I have to set bit 16. If I have to write something on bit 1, I have to set bit 17. If I

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Chris Zhong
On 12/11/2014 03:06 PM, Joe Perches wrote: On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote: On 2014/12/11 14:37, Joe Perches wrote: On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote: [] So If I have to write something on bit 0, I have to set bit 16. If I have to write

Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY

2014-12-10 Thread Yunzhi Li
Hi Kishon: On 2014/12/11 14:02, Kishon Vijay Abraham I wrote: Hi, On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote: This patch to add a generic PHY driver for ROCKCHIP usb PHYs, currently this driver can support RK3288. The RK3288 SoC have three independent USB PHY IPs which are all