Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-07 Thread Maxime Coquelin
2015-04-03 19:43 GMT+02:00 Joe Perches j...@perches.com: On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. trivia: diff --git a/drivers/tty/serial/stm32-usart.c

Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-07 Thread Maxime Coquelin
2015-04-04 0:04 GMT+02:00 Andy Shevchenko andy.shevche...@gmail.com: On Fri, Apr 3, 2015 at 8:01 PM, Maxime Coquelin mcoquelin.st...@gmail.com wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. Few minor comments. Tested-by: Chanwoo Choi

Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-03 Thread Peter Hurley
On 04/03/2015 01:01 PM, Maxime Coquelin wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. Reviewed-by: Peter Hurley pe...@hurleysoftware.com PS - I saw Rob's comment about 'hw-flow-ctrl' vs 'auto-flow-control' and I'm ok with either so feel free

Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-03 Thread Joe Perches
On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. trivia: diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c [] +static struct uart_ops stm32_uart_ops = {

[PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-03 Thread Maxime Coquelin
This drivers adds support to the STM32 USART controller, which is a standard serial driver. Tested-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Maxime Coquelin mcoquelin.st...@gmail.com --- drivers/tty/serial/Kconfig | 17 + drivers/tty/serial/Makefile | 1 +

Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-03 Thread Andy Shevchenko
On Fri, Apr 3, 2015 at 8:01 PM, Maxime Coquelin mcoquelin.st...@gmail.com wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. Few minor comments. Tested-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Maxime Coquelin