Re: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero

2015-09-25 Thread Shawn Guo
On Fri, Sep 25, 2015 at 07:16:49PM +, Alonso Adrian wrote: > > Ah, sorry, I'm screwed on the previous review. So we still need the flag > > ZERO_OFFSET_VALID to convert invalid 0 mux_reg to -1. > > > > @Adrian, > > > > Will the following change just work for you? > @Shawn, yes the change wil

RE: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero

2015-09-25 Thread Alonso Adrian
gmail.com; devicetree@vger.kernel.org; Li Frank-B20596 > ; Garg Nitin-B37173 ; > Huang Yongcai-B20788 ; linux- > g...@vger.kernel.org; robh...@kernel.org; ker...@pengutronix.de; Gong > Yibin-B38343 > Subject: Re: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero >

Re: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero

2015-09-25 Thread Shawn Guo
On Fri, Sep 25, 2015 at 12:47:26PM +0200, Markus Pargmann wrote: > On Thu, Sep 24, 2015 at 03:54:00PM -0500, Adrian Alonso wrote: > > Allow mux_reg offset zero to be a valid pin_id, on imx7d > > mux_conf reg offset is zero for iomuxc-lspr controller > > > > Signed-off-by: Adrian Alonso > > --- >

Re: [PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero

2015-09-25 Thread Markus Pargmann
On Thu, Sep 24, 2015 at 03:54:00PM -0500, Adrian Alonso wrote: > Allow mux_reg offset zero to be a valid pin_id, on imx7d > mux_conf reg offset is zero for iomuxc-lspr controller > > Signed-off-by: Adrian Alonso > --- > Changes for V2: Resend > Changes for V3: Resend > Changes for V4: Simplify pi

[PATCH v5 4/7] pinctrl: freescale: imx: allow mux_reg offset zero

2015-09-24 Thread Adrian Alonso
Allow mux_reg offset zero to be a valid pin_id, on imx7d mux_conf reg offset is zero for iomuxc-lspr controller Signed-off-by: Adrian Alonso --- Changes for V2: Resend Changes for V3: Resend Changes for V4: Simplify pin_id assigment when ZERO_OFFSET_VALID is set Changes for V5: - Drop patch pinct