Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-30 Thread Antoine Ténart
Hello, On Tue, Jun 24, 2014 at 05:37:56PM +0530, Varka Bhadram wrote: > On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: > >On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: > >>+ > >>+static struct phy *phy_berlin_sata_phy_xlate(struct device *dev, > >>+

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Lee Jones
On Tue, 24 Jun 2014, Varka Bhadram wrote: > On 06/24/2014 05:45 PM, Lee Jones wrote: > >On Tue, 24 Jun 2014, Varka Bhadram wrote: > >>On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: > >>>On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: > The Berlin SoC has a two SATA ports. Add a P

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Varka Bhadram
On 06/24/2014 05:45 PM, Lee Jones wrote: On Tue, 24 Jun 2014, Varka Bhadram wrote: On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us t

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Lee Jones
On Tue, 24 Jun 2014, Varka Bhadram wrote: > On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: > >On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: > >>The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. > >> > >>The mode selection can let us think this PHY can be configur

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Varka Bhadram
On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us think this PHY can be configured to fit other purposes. But there are reasons to

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-24 Thread Kishon Vijay Abraham I
Hi, On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote: > The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. > > The mode selection can let us think this PHY can be configured to fit > other purposes. But there are reasons to think the SATA mode will be > the only one usable

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-23 Thread Antoine Ténart
Sebastian, On Tue, Jun 17, 2014 at 08:17:02PM +0200, Sebastian Hesselbarth wrote: > On 06/16/2014 12:26 PM, Antoine Ténart wrote: > > + > > +#define PHY_BASE 0x200 > > Antoine, > > I gave your Berlin AHCI patches a try on BG2. I finally got it working > but BG2 has a different PHY_BASE

Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-17 Thread Sebastian Hesselbarth
On 06/16/2014 12:26 PM, Antoine Ténart wrote: > The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. > > The mode selection can let us think this PHY can be configured to fit > other purposes. But there are reasons to think the SATA mode will be > the only one usable: the PHY regi

[PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-16 Thread Antoine Ténart
The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us think this PHY can be configured to fit other purposes. But there are reasons to think the SATA mode will be the only one usable: the PHY registers are only accessible indirectly through two registe