Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Yong Wu
On Wed, 2015-12-16 at 12:48 +, Robin Murphy wrote: > On 16/12/15 05:59, Yong Wu wrote: > > On Tue, 2015-12-15 at 12:37 +, Robin Murphy wrote: > >> On 15/12/15 03:28, Yong Wu wrote: > >>> On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: > On Tue, Dec 08, 2015 at 05:49:12PM +0800,

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Joerg Roedel
On Tue, Dec 15, 2015 at 12:37:34PM +, Robin Murphy wrote: > The potential issue I *do* see, looking more closely, is that > iommu_group_get_for_dev() is setting group->domain but not calling > the attach_dev callback, which looks wrong... Attaching the device happens from

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Robin Murphy
On 16/12/15 05:59, Yong Wu wrote: On Tue, 2015-12-15 at 12:37 +, Robin Murphy wrote: On 15/12/15 03:28, Yong Wu wrote: On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: +static int mtk_iommu_attach_device(struct iommu_domain

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-15 Thread Yong Wu
On Tue, 2015-12-15 at 12:37 +, Robin Murphy wrote: > On 15/12/15 03:28, Yong Wu wrote: > > On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: > >> On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: > >>> +static int mtk_iommu_attach_device(struct iommu_domain *domain, > >>> +

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-15 Thread Robin Murphy
On 15/12/15 03:28, Yong Wu wrote: On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: +static int mtk_iommu_attach_device(struct iommu_domain *domain, + struct device *dev) +{ + struct

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-14 Thread Yong Wu
On Mon, 2015-12-14 at 19:19 +0100, Matthias Brugger wrote: > > On 08/12/15 10:49, Yong Wu wrote: > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > > > Signed-off-by: Yong Wu > > --- [...] > > +static void mtk_iommu_config(struct

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-14 Thread Yong Wu
On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: > On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: > > +static int mtk_iommu_attach_device(struct iommu_domain *domain, > > + struct device *dev) > > +{ > > + struct mtk_iommu_domain *dom =

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-14 Thread Joerg Roedel
On Tue, Dec 08, 2015 at 05:49:12PM +0800, Yong Wu wrote: > +static int mtk_iommu_attach_device(struct iommu_domain *domain, > +struct device *dev) > +{ > + struct mtk_iommu_domain *dom = to_mtk_domain(domain); > + struct mtk_iommu_client_priv *priv =

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-14 Thread Matthias Brugger
On 08/12/15 10:49, Yong Wu wrote: This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu --- drivers/iommu/Kconfig | 15 + drivers/iommu/Makefile| 1 + drivers/iommu/mtk_iommu.c | 752

[PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-08 Thread Yong Wu
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu --- drivers/iommu/Kconfig | 15 + drivers/iommu/Makefile| 1 + drivers/iommu/mtk_iommu.c | 752 ++ 3 files changed,

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-08 Thread kbuild test robot
Hi Yong, [auto build test ERROR on tegra/for-next] [also build test ERROR on v4.4-rc4 next-20151208] url: https://github.com/0day-ci/linux/commits/Yong-Wu/MT8173-IOMMU-SUPPORT/20151208-175252 base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux for-next config: