Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis.

2015-07-15 Thread Srinivas Kandagatla
Thanks Stephen, On 14/07/15 23:06, Stephen Boyd wrote: On 07/10, Srinivas Kandagatla wrote: +static int devm_nvmem_device_match(struct device *dev, void *res, void *data) +{ + struct nvmem_device **nvmem = res; + + if (!nvmem || !*nvmem) { + WARN_ON(!nvmem || !*nvmem);

Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis.

2015-07-14 Thread Stephen Boyd
On 07/10, Srinivas Kandagatla wrote: > +static int devm_nvmem_device_match(struct device *dev, void *res, void *data) > +{ > + struct nvmem_device **nvmem = res; > + > + if (!nvmem || !*nvmem) { > + WARN_ON(!nvmem || !*nvmem); This could be if (WARN_ON(!nvmem || !*nvme

Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis.

2015-07-10 Thread Joe Perches
On Fri, 2015-07-10 at 10:45 +0100, Srinivas Kandagatla wrote: > This patch adds read/write apis which are based on nvmem_device. More trivia: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > +static struct nvmem_device *nvmem_find(const char *name) > +{ > + struct device *d; > +

[PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis.

2015-07-10 Thread Srinivas Kandagatla
This patch adds read/write apis which are based on nvmem_device. It is common that the drivers like omap cape manager or qcom cpr driver to access bytes directly at particular offset in the eeprom and not from nvmem cell info in DT. These driver would need to get access to the nvmem directly, which