Re: [PATCH v8 4/7] qcom: pm: Add cpu low power mode functions

2014-10-09 Thread Stephen Boyd
On 10/09, Stephen Boyd wrote: > On 10/09, Lina Iyer wrote: > > On Wed, Oct 08 2014 at 19:17 -0600, Stephen Boyd wrote: > > > > >>+static int __init qcom_pm_device_init(void) > > >>+{ > > >>+ platform_device_register(&qcom_cpuidle_device); > > >>+ > > > > > >This is wrong. We're going to register a

Re: [PATCH v8 4/7] qcom: pm: Add cpu low power mode functions

2014-10-09 Thread Stephen Boyd
On 10/09, Lina Iyer wrote: > On Wed, Oct 08 2014 at 19:17 -0600, Stephen Boyd wrote: > > >>+static int __init qcom_pm_device_init(void) > >>+{ > >>+ platform_device_register(&qcom_cpuidle_device); > >>+ > > > >This is wrong. We're going to register a platform device whenever > >this file is incl

Re: [PATCH v8 4/7] qcom: pm: Add cpu low power mode functions

2014-10-09 Thread Lina Iyer
On Wed, Oct 08 2014 at 19:17 -0600, Stephen Boyd wrote: On 10/07/2014 02:41 PM, Lina Iyer wrote: + +static struct platform_device qcom_cpuidle_device = { + .name = "qcom_cpuidle", + .id= -1, + .dev.platform_data = qcom_cpu_pm_enter_sleep, +}; + S

Re: [PATCH v8 4/7] qcom: pm: Add cpu low power mode functions

2014-10-08 Thread Stephen Boyd
On 10/07/2014 02:41 PM, Lina Iyer wrote: + +static struct platform_device qcom_cpuidle_device = { + .name = "qcom_cpuidle", + .id= -1, + .dev.platform_data = qcom_cpu_pm_enter_sleep, +}; + Same comment as last time, doesn't need to be static. +s

[PATCH v8 4/7] qcom: pm: Add cpu low power mode functions

2014-10-07 Thread Lina Iyer
Add interface layer to abstract and handle hardware specific functionality for executing various cpu low power modes in QCOM chipsets. QCOM cpus support multiple low power modes. The C-States are defined as - * Standby * Retention (clock gating at lower power) * Standalone Power Colla