Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-23 Thread Juergen Borleis
Hi Jonathan, On Saturday 21 November 2015 18:48:10 Jonathan Cameron wrote: > [...] > Another personal preference. I'd not bother wrapping these single line > calls up but rather just make them inline. They don't in of > themselves add much to my mind. Still this one is very much up to you > as

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-23 Thread Markus Pargmann
On Saturday 21 November 2015 17:48:10 Jonathan Cameron wrote: > On 16/11/15 12:01, Markus Pargmann wrote: > > This is a driver for the imx25 ADC/TSC module. It controls the > > touchscreen conversion queue and creates a touchscreen input device. > > The driver currently only supports 4 wire

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-21 Thread Jonathan Cameron
On 16/11/15 12:01, Markus Pargmann wrote: > This is a driver for the imx25 ADC/TSC module. It controls the > touchscreen conversion queue and creates a touchscreen input device. > The driver currently only supports 4 wire touchscreens. The driver uses > a simple conversion queue of precharge,

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-21 Thread Jonathan Cameron
On 21/11/15 17:48, Jonathan Cameron wrote: > On 16/11/15 12:01, Markus Pargmann wrote: >> This is a driver for the imx25 ADC/TSC module. It controls the >> touchscreen conversion queue and creates a touchscreen input device. >> The driver currently only supports 4 wire touchscreens. The driver

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-20 Thread Markus Pargmann
Hi, On Tuesday 17 November 2015 10:17:20 Dmitry Torokhov wrote: > On Mon, Nov 16, 2015 at 01:01:07PM +0100, Markus Pargmann wrote: > > This is a driver for the imx25 ADC/TSC module. It controls the > > touchscreen conversion queue and creates a touchscreen input device. > > The driver currently

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-17 Thread Dmitry Torokhov
On Mon, Nov 16, 2015 at 01:01:07PM +0100, Markus Pargmann wrote: > This is a driver for the imx25 ADC/TSC module. It controls the > touchscreen conversion queue and creates a touchscreen input device. > The driver currently only supports 4 wire touchscreens. The driver uses > a simple conversion

[PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-16 Thread Markus Pargmann
This is a driver for the imx25 ADC/TSC module. It controls the touchscreen conversion queue and creates a touchscreen input device. The driver currently only supports 4 wire touchscreens. The driver uses a simple conversion queue of precharge, touch detection, X measurement, Y measurement,