Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 01/03/14 11:17, Jonathan Cameron wrote: On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel The error handling needs tidying up. Otherwise this looks fine to me. Note that you (r

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-03-01 Thread Jonathan Cameron
On 26/02/14 00:46, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel The error handling needs tidying up. Otherwise this looks fine to me. Note that you (really me) may get some grief over the DT bin

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
On Fri, Feb 28, 2014 at 9:32 PM, Belisko Marek wrote: > Hi Sebastian, > > On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: >> On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: >>> Well I've tried and it's worse :). I got during booting: >>> [2.218383] ERROR: could not ge

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-28 Thread Belisko Marek
Hi Sebastian, On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel wrote: > On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: >> Well I've tried and it's worse :). I got during booting: >> [2.218383] ERROR: could not get IIO channel /battery:temp(0) >> [2.224639] platform batte

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Sebastian Reichel
On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote: > Well I've tried and it's worse :). I got during booting: > [2.218383] ERROR: could not get IIO channel /battery:temp(0) > [2.224639] platform battery.4: Driver twl4030_madc_battery > requests probe deferral > Not sure if it's

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-27 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 10:54 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: >> [...] >> > + int val, err; >> > + err = iio_read_channel_average_raw(channel, &val); >> Where this function comes from? I cannot find it

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote: > [...] > > + int val, err; > > + err = iio_read_channel_average_raw(channel, &val); > Where this function comes from? I cannot find it in current linux-next > (only iio_read_channel_raw()). Am I missing some patches? T

Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-26 Thread Belisko Marek
Hi Sebastian, On Wed, Feb 26, 2014 at 1:46 AM, Sebastian Reichel wrote: > Update rx51-battery driver to use the new IIO API of > twl4030-madc and add DT support. > > Signed-off-by: Sebastian Reichel > --- > drivers/power/rx51_battery.c | 68 > +--- > 1 f

[PATCHv1 1/2] rx51_battery: convert to iio consumer

2014-02-25 Thread Sebastian Reichel
Update rx51-battery driver to use the new IIO API of twl4030-madc and add DT support. Signed-off-by: Sebastian Reichel --- drivers/power/rx51_battery.c | 68 +--- 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/power/rx51_battery.c