RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-02 Thread li.xi...@freescale.com
...@ti.com; devicetree@vger.kernel.org; linux-arm- ker...@lists.infradead.org; linux...@vger.kernel.org; alsa-devel@alsa- project.org; Guo Shawn-R65073; Nicolin Chen; linux-ker...@vger.kernel.org Subject: Re: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code

Re: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread Kuninori Morimoto
Hi Xiubo Thank you for your patch. This clean-up is very nice for me. But, I have 1 small comment asoc_simple_card_sub_parse_of(struct device_node *np, struct asoc_simple_dai *dai, struct device_node **p_node, -

RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
Hi Xiubo Thank you for your patch. This clean-up is very nice for me. But, I have 1 small comment asoc_simple_card_sub_parse_of(struct device_node *np, struct asoc_simple_dai *dai, struct device_node **p_node, -

Re: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread Andrew Lunn
On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote: This patch merge single DAI link and muti-DAI links code together, and simply the simple-card driver code. Hi Xiubo It would be good to note that this breaks the Binary API with DT blobs. Old blobs will not work with this new C code.

Re: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread Jason Cooper
As Andrew Lunn is on vacation until the 12th, please keep me in the Cc on future revisions of this patch. I'm not at all familiar with the audio subsystem, so I'll refrain from commenting on the details. However, with respect to DT, this is a no-go. This series breaks all boards in the field as

Re: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread Mark Brown
On Mon, Sep 01, 2014 at 03:34:12PM +0200, Andrew Lunn wrote: On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote: This patch merge single DAI link and muti-DAI links code together, and simply the simple-card driver code. It would be good to note that this breaks the Binary API with DT

RE: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
On Mon, Sep 01, 2014 at 03:34:12PM +0200, Andrew Lunn wrote: On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote: This patch merge single DAI link and muti-DAI links code together, and simply the simple-card driver code. It would be good to note that this breaks the Binary API

[PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-08-31 Thread Xiubo Li
This patch merge single DAI link and muti-DAI links code together, and simply the simple-card driver code. And also do some other improvement: Since from the DAI format micro SND_SOC_DAIFMT_CBx_CFx, the 'CBx' mean Codec's bit clock is as master/slave and the 'CFx' mean Codec's frame clock is as