Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-09-01 Thread Mark Brown
On Fri, Aug 29, 2014 at 03:12:12PM +0800, Xiubo Li wrote: > The 'big-endian-data' property is originally used to indicate whether the > LSB firstly or MSB firstly will be transmitted to the CODEC or received > from the CODEC, and there has nothing relation to the memory data. Applied, thanks. si

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Nicolin Chen
On Fri, Aug 29, 2014 at 08:11:41PM +0100, Mark Brown wrote: > On Fri, Aug 29, 2014 at 10:40:20AM -0700, Nicolin Chen wrote: > > > Agreed, it's better to be described in the commit comments as well. > > > And regarding the compatibility with the old DT, I personally prefer > > it to be added in th

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Mark Brown
On Fri, Aug 29, 2014 at 10:40:20AM -0700, Nicolin Chen wrote: > Agreed, it's better to be described in the commit comments as well. > And regarding the compatibility with the old DT, I personally prefer > it to be added in the change for safety but if this case is allowable > which I'm not so sur

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Nicolin Chen
On Fri, Aug 29, 2014 at 06:26:02PM +0100, Mark Rutland wrote: > On Fri, Aug 29, 2014 at 05:40:11PM +0100, Nicolin Chen wrote: > > On Fri, Aug 29, 2014 at 12:59:43PM +0100, Mark Brown wrote: > > > On Fri, Aug 29, 2014 at 12:06:01PM +0100, Mark Rutland wrote: > > > > On Fri, Aug 29, 2014 at 08:12:12A

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 05:40:11PM +0100, Nicolin Chen wrote: > On Fri, Aug 29, 2014 at 12:59:43PM +0100, Mark Brown wrote: > > On Fri, Aug 29, 2014 at 12:06:01PM +0100, Mark Rutland wrote: > > > On Fri, Aug 29, 2014 at 08:12:12AM +0100, Xiubo Li wrote: > > > > > > The 'big-endian-data' property i

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Nicolin Chen
On Fri, Aug 29, 2014 at 12:59:43PM +0100, Mark Brown wrote: > On Fri, Aug 29, 2014 at 12:06:01PM +0100, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 08:12:12AM +0100, Xiubo Li wrote: > > > > The 'big-endian-data' property is originally used to indicate whether the > > > LSB firstly or MSB first

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Mark Brown
On Fri, Aug 29, 2014 at 12:06:01PM +0100, Mark Rutland wrote: > On Fri, Aug 29, 2014 at 08:12:12AM +0100, Xiubo Li wrote: > > The 'big-endian-data' property is originally used to indicate whether the > > LSB firstly or MSB firstly will be transmitted to the CODEC or received > > from the CODEC, an

Re: [PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 08:12:12AM +0100, Xiubo Li wrote: > The 'big-endian-data' property is originally used to indicate whether the > LSB firstly or MSB firstly will be transmitted to the CODEC or received > from the CODEC, and there has nothing relation to the memory data. > > Generally, if the

[PATCHv2] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-29 Thread Xiubo Li
The 'big-endian-data' property is originally used to indicate whether the LSB firstly or MSB firstly will be transmitted to the CODEC or received from the CODEC, and there has nothing relation to the memory data. Generally, if the audio data in big endian format, which will be using the bytes reve